Fix the build command

[hayata-suenaga]

cc: @tgolen

Related Issues

GH_LINK: #12

This PR fixes the build command specified in package.json.

Problem

The "Publish package to npmjs" workflow failed here because of the incompatibility between a TypeScript configuration and an option passed to the TypeScript compiler.

Specifically, the following configuration and option conflicted with each other.

tsconfig.json: "noEmit": true
package.json: npx tsc --emitDeclarationOnly

During the build, --emitDeclarationOnly instructs tsc (TypeScript compiler) to generate only d.ts files.

If you're curious, the actual compilation is handled by babel

However, the noEmit option, which is turned on in tsconfig.json, tells tsc to not to generate anything at all, conflicting with the above emitDeclarationOnly option.

Fix

Removes "noEmit": true from tsconfig.json. This is safe because the ts command in package.json, which is used to type-check, already passes --noEmit option.

Cleanup

Removes the ts:declarations command from package.json and directly run the tsc command inside the build command.

Test

Run npm run build in the project root directory. Confirm that the command runs without an error and the dist folder is created.

[grgia]

Great job on the description of this PR @hayata-suenaga, that was really helpful!

[grgia]

I'll hold off on merging incase @tgolen had any comments, feel free to merge @hayata-suenaga

[hayata-suenaga]

Merging this because this is blocking Expensify/App#22703

[melvin-bot]

@hayata-suenaga looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[hayata-suenaga]

npm package version and the version specified in package.json is out of sync, but build command succeeded.