Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the default map view with ExpensiMap #22703

Closed
3 tasks done
neil-marcellini opened this issue Jul 11, 2023 · 17 comments
Closed
3 tasks done

Create the default map view with ExpensiMap #22703

neil-marcellini opened this issue Jul 11, 2023 · 17 comments
Assignees
@hayata-suenaga
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Jul 11, 2023 •
edited by hayata-suenaga
Loading

Please follow the plan in the design doc.

TODO List

  • Explore Mapbox's web and react native API
  • Read the project doc again to check what API is needed in App
  • Figure out how to merge two platforms' API
@luacmartins luacmartins self-assigned this Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@luacmartins
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 17, 2023
@luacmartins
Copy link
Contributor

On hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 25, 2023
@luacmartins
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 27, 2023
@luacmartins
Copy link
Contributor

Latest update here - https://expensify.slack.com/archives/C05DWUDHVK7/p1690821182695819?thread_ts=1690580800.136149&cid=C05DWUDHVK7

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 31, 2023
@luacmartins
Copy link
Contributor

On hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Aug 2, 2023
Merged
@neil-marcellini neil-marcellini changed the title [HOLD 22701] Create the default map view with ExpensiMap [HOLD react-native-x-maps 7] Create the default map view with ExpensiMap Aug 2, 2023
@luacmartins
Copy link
Contributor

@hayata-suenaga reached out and is interested in working on this issue. So I'll pass it over to him.

@hayata-suenaga
Copy link
Contributor

I texted with @luacmartins and expressed my interest in taking over this issue. Assigning myself

@hayata-suenaga
Copy link
Contributor

A small todo list in OP ⬆️

@neil-marcellini
Copy link
Contributor Author

Cool thanks for picking it up! I would suggest following the plan in the doc exactly as it's written and let us know if you run into any problems along the way. It should all work smoothly and you won't have to spend quite as much time reading up on the libraries, etc.

@hayata-suenaga
Copy link
Contributor

ah I meant more like "reading documentation linked in the design doc"

you already did good research so I agree this won't take time (more like following the design doc)

@hayata-suenaga hayata-suenaga mentioned this issue Aug 3, 2023
Merged
@neil-marcellini neil-marcellini changed the title [HOLD react-native-x-maps 7] Create the default map view with ExpensiMap Create the default map view with ExpensiMap Aug 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2023
@hayata-suenaga
Copy link
Contributor

I keep working on this today

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
@neil-marcellini neil-marcellini mentioned this issue Aug 8, 2023
Merged
@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2023
@hayata-suenaga
Copy link
Contributor

working on it

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2023
@neil-marcellini neil-marcellini mentioned this issue Aug 9, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 11, 2023
@hayata-suenaga
Copy link
Contributor

this will be closed when this PR is merged and deployed

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 17, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Aug 18, 2023
Closed
57 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 18, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Aug 18, 2023
Merged
57 tasks
@tgolen tgolen added Hourly KSv2 and removed Weekly KSv2 labels Aug 22, 2023
@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Hourly KSv2 labels Oct 17, 2023
@hayata-suenaga
Copy link
Contributor

I believe we can close this issue now 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayata-suenaga hayata-suenaga

Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tgolen @luacmartins @neil-marcellini @hayata-suenaga