Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed characters support between [] for Hyperlinks #401

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

mananjadhav
Copy link
Contributor

@stitesExpensify will you please review this updated PR?

  • Updated the regex for handling characters between [] for the hyperlink.

Fixed Issues

$ Fixes: Expensify/App#4229

Tests

  1. "Test markdown and URL links with inconsistent starting and closing parens" covers testing of the given changes
  2. Tested against incorrect pairs, symbols, and special characters handling

QA

  1. Test with different string patterns for the URLs
  2. Explore complex strings to validate the regex
  3. Regression has to be run for inconsistent parenthesis and links with style

@mananjadhav mananjadhav requested a review from a team as a code owner July 27, 2021 23:07
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 27, 2021 23:07
@stitesExpensify
Copy link
Contributor

As mentioned here we should have Applause do extra QA to make sure the new pattern does not break things.

@stitesExpensify stitesExpensify merged commit e83c699 into Expensify:master Jul 28, 2021
@parasharrajat
Copy link
Member

parasharrajat commented Jul 29, 2021

So one behaviour change from the changes here

  1. [ link `test`](google.com) will become => link test which was not the case earlier.

cc: @stitesExpensify

@mananjadhav
Copy link
Contributor Author

@parasharrajat Is that different from what is expected?

@parasharrajat
Copy link
Member

I think it's fine as Github supports it.

@stitesExpensify
Copy link
Contributor

is "link" in "link test" still a hyperlink?

@parasharrajat
Copy link
Member

parasharrajat commented Jul 29, 2021

Yes link test

@stitesExpensify
Copy link
Contributor

Cool, I think that's fine then. Thanks for the heads up though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperlink markdown doesn't work if the ] is preceded by an (
3 participants