-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed characters support between [] for Hyperlinks #400
Fixed characters support between [] for Hyperlinks #400
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I'll let @stitesExpensify do the final review and merge! |
I think it is good to let QA know that we should try complex combinations for the markup. Just to make sure nothing is broken with existing rules. |
Sounds great @parasharrajat - Let's do that on the https://github.com/Expensify/App PR since I am not sure they get a checklist for these changes. |
Hmm it looks like the commits are not PGP signed, so we can't merge this. @mananjadhav we're going to need you to check out step 8 here and then create a new PR with the same changes. |
Noted. Closing and raising another PR. |
#401 PR raised with signed commits. |
Can someone please review it?
Fixed Issues
$ Fixes: Expensify/App#4229
Tests
QA