Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports big screens mobile devices for popover menu #6278

Merged

Conversation

AlfredoAlc
Copy link
Contributor

Details

Changes the way it renders the popover menu for iPad, for the same as Web and Desktop.

Fixed Issues

$ #5754

Tests

  1. Enter Expensify App with an iPad.
  2. Press the FAB(Plus button).
  3. The Popover menu should appear the way it appears in Web and Desktop.(Animated from the side instead of from bottom)

QA Steps

  1. Enter Expensify App with an iPad.
  2. Press the FAB(Plus button).
  3. The Popover menu should appear the way it appears in Web and Desktop.(Animated from the side instead of from bottom)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-11-10 at 17 06 28

Desktop

Screen Shot 2021-11-10 at 17 05 24

iOS

iPhone

iPhone

iPad
ipad.mp4

Android

Android

@AlfredoAlc AlfredoAlc requested a review from a team as a code owner November 11, 2021 01:07
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team November 11, 2021 01:07
johnmlee101
johnmlee101 previously approved these changes Nov 22, 2021
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please resolve conflicts and I'll merge!

@johnmlee101
Copy link
Contributor

Thanks for your patience!

@johnmlee101 johnmlee101 merged commit 5e781be into Expensify:main Nov 24, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat
Copy link
Member

@AlfredoAlc the PR is reverted. Would you please resubmit it without the regression?

@AlfredoAlc
Copy link
Contributor Author

Yes, I will be working on fixing those issues!

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants