Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad - Chat - Popover menu animated from the bottom instead of from side #6529

Closed
kavimuru opened this issue Nov 30, 2021 · 7 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #6278

Action Performed:

  1. Enter Expensify App with an iPad.
  2. Press the FAB(Plus button)

Expected Result:

The Popover menu should appear the way it appears in Web and Desktop.(Animated from the side instead of from bottom)

Actual Result:

Popover menu animated from the bottom instead of from side

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS - iPad Portrait

Version Number: 1.1.17-1

Reproducible in staging?: Yes

Reproducible in production?: PR issue

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Issue was found when executing #6278

Bug5350996_RPReplay_Final1638226171.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 30, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@deetergp
Copy link
Contributor

This is the way the iOS app functions on iPhone. How is it that we expect that the iOS app should function like desktop & web on the iPad? I'm not sure I agree that this is a blocker. Thoughts @roryabraham @marcaaron @parasharrajat?

@parasharrajat
Copy link
Member

This is working as expected. On bigger screens or landscape iPad, menu should animate from left

You can easily evaluate it. If you are able see both LHN and report screen then menu should not be full screen and animation should be same as desktop.

@deetergp
Copy link
Contributor

If that's the case then yes, it is a bug, it's behaving that way even in landscape mode:
IMG_2F98787CDF97-1

@Jag96
Copy link
Contributor

Jag96 commented Nov 30, 2021

How does this behave on production? #6278 was the PR for this, but it was reverted in #6523 since it caused other regressions, so if the behavior we're seeing now is the same on production I think this can be closed in favor of #5754.

@deetergp
Copy link
Contributor

Great point! I just pulled down the production version of the app and it behaves the same way. So not a blocker. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants