(2nd) Fix long loading from public and redirect to last accessed report #50629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fix Sign in long loading when navigating via public room link and logging in as a new account.
Reported regressions:
#50549 can't replicated even when my PR applied
#50560 will need separate investigation because that issue related to
withOnyx
migration and not directly related to the main logic in this PR #50560 (comment)Fixed Issues
$ #48715
$ #50578
PROPOSAL: #48715 (comment)
Tests
[x] Verify that no errors appear in the JS console
Offline tests
Same as test
QA Steps
Same as test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Kapture.2024-10-12.at.11.25.46.mp4
Android: mWeb Chrome
Kapture.2024-10-12.at.11.29.45.mp4
iOS: Native
Kapture.2024-10-12.at.11.21.55.mp4
iOS: mWeb Safari
Kapture.2024-10-12.at.11.34.27.mp4
MacOS: Chrome / Safari
Kapture.2024-10-12.at.11.17.09.mp4
MacOS: Desktop
Kapture.2024-10-12.at.11.12.11.mp4