[HOLD for payment 2024-10-17] [$250] Sign in - Account settings long loading if navigate via public room link & login as new account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ponikarchuks+106924@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #48144

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log out
3. Go to this link https://staging.new.expensify.com/r/7075912447943023
4. Tap sign in
5. Enter credentials and log in as a new Gmail account

Expected Result:

Account settings loads fine

Actual Result:

Account settings long loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6595301_1725625415082.A_clear_anonymous_user_records_after_login.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836652520479378795
• Upwork Job ID: 1836652520479378795
• Last Price Increase: 2024-09-26
• Automatic offers:
• wildan-m | Contributor | 104259835

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bfitzexpensify]

Checking in on the other issue here

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: confirming if the other PR caused this

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jjcoffee]

This doesn't appear to be related to #47806 - I can repro with the changes from there reverted. It's probably a BE issue as there are no personalDetails returned in the SignUpUser call.

[melvin-bot]

@bfitzexpensify, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

Thanks for confirming @jjcoffee . I'm going to move this to internal since this sounds like a BE issue

[VictoriaExpensify]

Not overdue

[trjExpensify]

Is this bug specific to the public rooms flow and on Android native only? If so, that was a project in #vip-vsb, and I think @jasperhuangg might be good to offer insight into that.

[jasperhuangg]

@jjcoffee The SignUpUser command isn't in charge of returning personal details, ReconnectApp/OpenApp is.

cc @marcochavezf IIRC you implemented this flow, it seems like we're not calling ReconnectApp when the user is signed in from the public room, which I think could be preventing us from loading their personal details.

Under normal circumstances when we sign up a new user we do call it:

So I believe this issue lies in the front-end and can be worked on externally, I think we just need to figure out why we're not calling ReconnectApp for that particular flow.

[thesahindia]

The solution looks fine to me @lakchote.

[lakchote]

@wildan-m I have a few more questions.

1. If the user hasn't in the navigation's history a previous page, won't removing this code will prevent the user from having a default redirect once the onboarding modal is closed?

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 73 to 77 in 76c5c81

	// Only navigate to concierge chat when central pane is visible
	// Otherwise stay on the chats screen.
	if (!shouldUseNarrowLayout && !route.params?.backTo) {
	Report.navigateToConciergeChat();
	}

2. The original issue for that change is no longer reproducible even without that code [HOLD for payment 2024-08-02] [$250] Concierge chat is read as it's selected during the onboarding flow #44728

I couldn't find any indication on this in the issue's comments. Did you try it out yourself, by removing that code?

[wildan-m]

@lakchote

If the user hasn't in the navigation's history a previous page, won't removing this code will prevent the user from having a default redirect once the onboarding modal is closed?

I'm not sure about this case, can you suggest possible reproduction steps? without that code the user will still redirected to concierge by default

Kapture.2024-10-04.at.02.46.51.mp4

I couldn't find any indication on this in the issue's comments. Did you try it out yourself, by removing that code?

Yes, please watch the first and second case in this video,

Kapture.2024-10-04.at.02.56.50.mp4

The 1st case, concierge is unbolded, that is expected since that chat is selected
The 2nd case, concierge is keep bolded, that's expected since we are on public chat when logged in

Looking at the proposal root cause #44728 (comment) that issue is originally created to handle system chat, but I couldn't find anything about navigateToSystemChat in the latest main, I assume there is no redirection differentiation in the latest code

[lakchote]

Understood, thanks for testing.

@wildan-m's proposal LGTM.

[melvin-bot]

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@wildan-m @lakchote @bfitzexpensify @thesahindia this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[wildan-m]

creating the PR ...

[wildan-m]

@thesahindia The PR is ready #50278 thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix long loading from public and redirect to last accessed report #50278

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment automatic offer (Contributor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lakchote]

Regressions arised.

See #50278 (comment).

[wildan-m]

@lakchote, @thesahindia I've created this draft PR #50629 in case you are curious and also want to test.

Currently I only revert the withOnyx migration part to handle this issue:

• [$250] Desktop - User remains logged in after logging out on desktop app #50560

I can't reproduce other deploy blockers that potentially come from our PR:

• [$250] Onboarding - New user lands on workspace chat when 'Manage my team's expenses' selected in modal #50578
• Sign up - Central pane is blank after logging in with a new Expensifail account #50549

Let me know if you can reproduce the two issues mentioned above as I conduct more testing.