Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the password label in Plaid VBA flow #4530

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Aug 10, 2021

Details

See the issue for more context.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173525
$ #4548

Tests

How to test it locally: SO here.

Follow the Log Into Your Bank flow in Add Bank Account, login in through Plaid, select Plaid Saving and make sure the password field says Enter Expensify password if English is selected as your language.

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from a team as a code owner August 10, 2021 17:46
@mountiny mountiny self-assigned this Aug 10, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team August 10, 2021 17:47
@shawnborton
Copy link
Contributor

Chiming in here quickly - it looks like the select menu is missing a small label above the value:
image

@mountiny
Copy link
Contributor Author

@shawnborton You are right! I have raised the issue in here, but that was a wrong place probably.

The thing is that there was no label originally. What label would you propose for this select, or should I ask in #product?

@shawnborton
Copy link
Contributor

I think it could simply say "Account" or "Choose account" - looks like @roryabraham also reported this.

@mountiny
Copy link
Contributor Author

@Jag96 For context for anyone else coming across this in future, I have asked in Slack here and we decided to use Account as a label. It can be easily changed in future if it would be a problem.

image

I have updated the copy and added the label, should be ready for a review!

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jag96 Jag96 merged commit dfa3eb1 into main Aug 11, 2021
@Jag96 Jag96 deleted the vit-updatePasswordCopy branch August 11, 2021 19:19
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants