Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bank Account - Bank account picker is missing a label #4548

Closed
isagoico opened this issue Aug 11, 2021 · 5 comments
Closed

Add Bank Account - Bank account picker is missing a label #4548

isagoico opened this issue Aug 11, 2021 · 5 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to staging.new.expensify.com/bank-account/new
  2. Click on log into your bank and enter test credentials
  3. Select a bank account from the dropdown

Expected Result:

Dropdown label should be displayed.

Actual Result:

Dropdown label "Bank account" is not visible. Looks like a

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.0.83-1

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

On windows Chrome there's no weird padding but still no label

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @roryabraham https://expensify.slack.com/archives/C01GTK53T8Q/p1628645830194700

Add bank account picker is missing a label

@MelvinBot
Copy link

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

cc @kakajann

@mountiny mountiny self-assigned this Aug 11, 2021
@mountiny
Copy link
Contributor

This is being fixed in this PR here. At least for this particular Picker, maybe we would want to update the styles so the Picker looks normal even if we do not add a label.

That should be a new issue though.

@mountiny mountiny added the Reviewing Has a PR in review label Aug 11, 2021
@AndrewGable AndrewGable removed their assignment Aug 13, 2021
@MelvinBot
Copy link

@mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor

The PR has been deployed 3 days ago to production and no regressions have not been found on staging either on production, so I will close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants