-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD][WIP] Import and export Onyx snapshots #41557
Conversation
@@ -1,3 +1,5 @@ | |||
type LocalFileDownload = (fileName: string, textContent: string, successMessage?: string) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
successMessage was never actually used.
On Android can you just save it directly into the Downloads folder? Using the share button is super annoying in practice, because often you need to upload multiple files (a trace, video, logs, and now this) so it would be much easier to just have everything dumped straight to Downloads and skip the share button, like here: HIGH: [Debugability] [$250] Save client-side logs and profile traces to the Downloads folder |
Yes, pretty sure you can. I have only tested on desktop so far, but from what I remember when the local file download flow was created, on Android it just goes straight to downloads. |
# Conflicts: # src/languages/en.ts # src/languages/es.ts
# Conflicts: # src/components/ChatDetailsQuickActionsBar.tsx
@roryabraham would you mind closing this for now if you're not going to do anything with it? |
Since I haven't heard anything, I'm going to give this a courtesy-close :) |
Thanks, I saw your comment in an email but hadn't gotten to it yet. I am planning to circle back to this as soon as we fix the issues with infinite GetOlderActions and GetNewerActions loops. |
HOLD - needs Onyx update: Expensify/react-native-onyx#544
Details
Creates a way to export a full snapshot of Onyx data to a file, then import a full snapshot of Onyx data from a file. This can be used for debugging issues that only some people can reproduce on staging.
Patches added
Upstream PR for react-native-document-picker patch: react-native-documents/document-picker#718
Fixed Issues
$ https://expensify.slack.com/archives/C05LX9D6E07/p1714702412032799?thread_ts=1714656403.682529&cid=C05LX9D6E07
Tests / QA Steps
Account Settings
->Troubleshoot
Export app snapshot to file
Import app snapshot from file
Offline tests
None. This feature should work offline on iOS, Android, and desktop, but it's just for debugging so it's not important.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
desktop.mov