CRITICAL: [API Reliability] Workspace room does not load older messages due to infinite GetOlderActions calls

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-2
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714419709483439

Action Performed:

1. Open new dot app
2. Go to the workspace chat NewDot Test - Expensify US policy`

Expected Result:

The workspace chat should load all historical messages and requests

Actual Result:

The workspace chat is stuck looping through OpenReport over and over again. It will not load previous messages or requests, but it will load a recent receipt I uploaded today

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

CleanShot.2024-04-29.at.15.34.58.mp4

logs-2024-04-29 19_35_32.431.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @roryabraham

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[shawnborton]

cc @JmillsExpensify in case you want to add your case here too

[trjExpensify]

I've just experienced this as well in a pretty brand new test account. Logs here:

logs-2024-05-01 16_24_37.825.txt

Looks like OpenReport and GetOlderActions are in a constant loop:

2024-05-01_17-28-05.mp4

When I click on one of those Fetch finished loading: POST "<URL>?". rows in the console, I see this error as well:

{"code":666,"jsonCode":403,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"da7984df-628f-41f6-a2b8-ecd4499f7975","message":"Report not found","title":"","data":{"onyxData":[{"onyxMethod":"merge","key":"report_0","value":{"errorFields":{"notFound":{"1714580833933154":"Report not found"}}}}]},"htmlMessage":"","requestID":"87d123434d9c4164-LHR"}

[muttmuure]

I hit this one too. @gedu @adhorodyski @janicduplessis @Szymon20000 could your teams take a look at this?

[muttmuure]

posted a CPU profile to #newdot-performance https://expensify.slack.com/archives/C05LX9D6E07/p1714656403682529

[janicduplessis]

I will investigate this today

[roryabraham]

There was a very long slack thread about this today, but for this issue I have put together three PRs:

• [WIP] Ignore optimistic actions both ways #41558 to fix this issue per this proposal
• [HOLD for App onyx bump] Add getAllEntries function for Onyx. react-native-onyx#544 and [HOLD][WIP] Import and export Onyx snapshots #41557 to help test this issue per this proposal

Tomorrow I'll hopefully finish those up and we can test the fix with an AdHoc build, then if all is well fix this issue!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

I had this PR up to fix this, but it's likely that this will be fixed by #41644, which was based off my PR, and which we'll CP to fix another issue with clear reproduction steps

[roryabraham]

hmm ok melvin, not sure why you added the overdue label right back, but we just merged #41644 and it's being CP'd to staging here. Good chance this might be fixed now.

[muttmuure]

It's fixed for me!

[melvin-bot]

@janicduplessis, @roryabraham, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Just posted a fresh update here. Basically we are getting ready to come out of POC phase and try to get our solution ready to merge

[adelekennedy]

making progress!

[melvin-bot]

@janicduplessis, @roryabraham, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

Still following along here

[adelekennedy]

updates in slack thread

[roryabraham]

Now that #41962 is on prod, this should be fixed. Requested a retest: https://expensify.slack.com/archives/C9YU7BX5M/p1720819446079169

[shawnborton]

So I can easily see the historical chats in my Workspace chat, but one interesting thing is that it doesn't load the receipt images for my expenses unless I click into each expense:

Thoughts?

[roryabraham]

That looks like a real but separate bug (but a legit one we should report in #expensify-bugs). Going to close this issue as complete

[shawnborton]

Sounds good!