-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRITICAL: [API Reliability] Workspace room does not load older messages due to infinite GetOlderActions
calls
#41254
Comments
Triggered auto assignment to @adelekennedy ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
cc @JmillsExpensify in case you want to add your case here too |
I've just experienced this as well in a pretty brand new test account. Logs here: logs-2024-05-01 16_24_37.825.txt Looks like 2024-05-01_17-28-05.mp4When I click on one of those
|
I hit this one too. @gedu @adhorodyski @janicduplessis @Szymon20000 could your teams take a look at this? |
posted a CPU profile to #newdot-performance https://expensify.slack.com/archives/C05LX9D6E07/p1714656403682529 |
GetOlderActions
calls
I will investigate this today |
There was a very long slack thread about this today, but for this issue I have put together three PRs:
Tomorrow I'll hopefully finish those up and we can test the fix with an AdHoc build, then if all is well fix this issue! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
I had this PR up to fix this, but it's likely that this will be fixed by #41644, which was based off my PR, and which we'll CP to fix another issue with clear reproduction steps |
It's fixed for me! |
@janicduplessis, @roryabraham, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Just posted a fresh update here. Basically we are getting ready to come out of POC phase and try to get our solution ready to merge |
making progress! |
@janicduplessis, @roryabraham, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Still following along here |
updates in slack thread |
Now that #41962 is on prod, this should be fixed. Requested a retest: https://expensify.slack.com/archives/C9YU7BX5M/p1720819446079169 |
That looks like a real but separate bug (but a legit one we should report in |
Sounds good! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.67-2
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714419709483439
Action Performed:
Expected Result:
The workspace chat should load all historical messages and requests
Actual Result:
The workspace chat is stuck looping through OpenReport over and over again. It will not load previous messages or requests, but it will load a recent receipt I uploaded today
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
CleanShot.2024-04-29.at.15.34.58.mp4
logs-2024-04-29 19_35_32.431.txt
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @roryabrahamThe text was updated successfully, but these errors were encountered: