-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Architecture] Upgrade react-native-svg
#36007
[New Architecture] Upgrade react-native-svg
#36007
Conversation
react-native-svg
react-native-svg
react-native-svg
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-svg-upgrade.movAndroid: mWeb Chromemweb-chrome-svg-upgrade.moviOS: Nativeios-svg-upgrade.moviOS: mWeb Safarimweb-safari-svg-upgrade.movMacOS: Chrome / Safariweb-svg-upgrade.movMacOS: Desktopdesktop-svg-upgrade.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #35999 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Approved again so that @tgolen gets assigned on the PR. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀
|
Details
Fixed Issues
$ #35999
Tests
Make sure that SVGs are being displayed properly in the app, here's some of the things that you should check:
Offline tests
N/A
QA Steps
Make sure that SVGs are being displayed properly in the app, here's some of the things that you should check:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov