Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Upgrade react-native-svg #35999

Closed
j-piasecki opened this issue Feb 7, 2024 · 14 comments
Closed

[New architecture] Upgrade react-native-svg #35999

j-piasecki opened this issue Feb 7, 2024 · 14 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@j-piasecki
Copy link
Contributor

We need to upgrade react-native-svg in order to use the new architecture in the App.

More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293558602069

@j-piasecki j-piasecki added AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2 labels Feb 7, 2024

This comment was marked as outdated.

This comment was marked as resolved.

@BartoszGrajdek
Copy link
Contributor

Hey! I'm Bartosz from Software Mansion and I would like to work on this task.

@roryabraham
Copy link
Contributor

Not a new lib, just an upgrade. Recategorizing...

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App labels Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav
Copy link
Collaborator

@dylanexpensify Can you please assign this issue to me as I helped with the PR review?

@dylanexpensify
Copy link
Contributor

done! thanks Matt!

@mananjadhav
Copy link
Collaborator

Thanks @muttmuure @dylanexpensify

@roryabraham
Copy link
Contributor

@mananjadhav should be paid the standard rate of $500 for this PR review assuming no regressions

@mananjadhav
Copy link
Collaborator

@dylanexpensify This was deployed on production last week and should be ready for payout. Can you please post a payout summary?

This was a lib upgrade and hence checklist is not applicable.

@dylanexpensify
Copy link
Contributor

Sure can!

@dylanexpensify
Copy link
Contributor

Payment summary:

@JmillsExpensify
Copy link

$500 approved for @mananjadhav based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

8 participants