-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clear task pendingAction upon success #22746
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@samh-nl Could you kindly add the clearing of the pending action to cancel task action as well?. |
@abdulrahuman5196 Thanks for the message. I will commit this shortly. |
recheck |
@abdulrahuman5196 The second commit contains the requested addition. |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-13.at.9.47.58.PM.mp4Mobile Web - Chromeaz_recorder_20230713_221142.mp4Mobile Web - SafariUntitled.3.mp4DesktopScreen.Recording.2023-07-13.at.10.20.37.PM.mp4iOSScreen.Recording.2023-07-13.at.10.16.29.PM.mp4Androidaz_recorder_20230713_223435.mp4 |
NAB: @samh-nl Kindly add the cancel task to author's checklist test case as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours @luacmartins . Good to merge
🎀 👀 🎀
C+ Reviewed
@abdulrahuman5196 Thanks for mentioning. I have updated the test steps. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.41-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.42-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀
|
Details
When completing, re-opening or canceling a task,
pendingAction
is optimistically set, however previously it was not set to null when the action succeeded. This has now been corrected.Fixed Issues
$ #22060
PROPOSAL: #22060 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Chrome.Screen.Recording.2023-07-12.at.11.36.48.mp4
Mobile Web - Chrome
mWeb.chrome.Screen.Recording.2023-07-12.at.15.07.26.mp4
Mobile Web - Safari
mWeb.safari.Screen.Recording.2023-07-12.at.13.04.01.mp4
Desktop
Desktop.Screen.Recording.2023-07-12.at.12.09.03.mp4
iOS
Native.ios.Screen.Recording.2023-07-12.at.12.23.25.mp4
Android
Native.Android.Screen.Recording.2023-07-12.at.12.47.39.mp4