[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-04] [HOLD for payment 2023-08-24] [HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [HOLD for payment 2023-07-24] [HOLD for payment 2023-07-21] [HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Implement custom buttons

[shawnborton]

Unfortunately we can't really add any styles to the out-of-the-box RN buttons:

However, it seems like there are a lot of ready-to-use solutions out there using the TouchableXXXX components.

Here is a good example from Facebook: https://github.com/facebook/react-native/blob/master/Libraries/Components/Button.js

More reading: https://stackoverflow.com/questions/43585297/react-native-button-style-not-work

I think this is high priority because it will help prove that we have full style control over simple form elements.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e492b331c8133b5b
• Upwork Job ID: 1610264117874089984
• Last Price Increase: 2023-01-03

[shawnborton]

Actually... seems like we're good if we use the TouchableOpacity component.

[quinthar]

I agree this is valuable, but demoting to MEDIUM because it's only experienced once per session and will be instantly forgotten. yes those who study the code will have this question, but let's focus first on a flawless live demo.

[tgolen]

I think this is done already?

[shawnborton]

Yeah, TouchableOpacity seems to work fine for this. When we actually build this out in the future, we'd want to make our own custom button component where we can pass through things like isSuccess or isLarge or whatever

[Beamanator]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[Beamanator]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[Beamanator]

Job added to Upwork: https://www.upwork.com/jobs/~01e492b331c8133b5b

[Beamanator]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix eye icon bug #22356
• Do not use the replace in case of RHP as its fixing edge case #22355
• Hide only chat threads that haven't been commented on #22349

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: SelectionList multiple selection #22622

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [navigation-refactor] Style based approach for the three pane layout #22437

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Wildan/fix/21518/client pusher method #24407

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[tgolen]

hahaha.... oops. I guess using 123 as a test issue number wasn't great. I'm so sorry for all the noise here!