If a deleted parent doesn't have a thread anymore, hide it #22690

dangrous · 2023-07-11T20:25:37Z

Details

Hides the [Deleted message] of a parent of a thread if the thread no longer exists. Actually applies in a broader set of circumstances than listed in the linked issue (unless I'm missing something).

It introduces one slight UI weirdness that I'd love your thoughts on, reviewers! Namely, if you delete the last child message of a thread, you are still in that thread, with only the [Deleted message] there, but as soon as you leave that thread disappears. I think that that's fine? At least I'm not sure what else to do that would be better.

Additionally, there is some weirdness with how these tests behave offline, but I checked and it seems to be the same on dev (the thread still is shown in the parent report even if it's deleted) so I'm not worrying about that.

Fixed Issues

$ #21508
$ #22674

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

QA Steps

In any chat, add a message
Add another message as a thread off of that message
Delete the initial message, either from the parent report or the chat
Verify it is shown in both places as [Deleted message] and that the thread still exists and is accessible
Delete the message in the thread
Once you move away from the thread, ensure the thread no longer exists in the LHN
Ensure that there is no [Deleted message] in the parent chat anymore
[Additional tests for second issue]
Send a new message
Open a thread on that message, but don't actually send anything
Go back to the main chat
Set your connection to Slow 3G
Delete that message
Ensure you don't see [Deleted message] and the chat is fully deleted immediately.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Still having trouble with mWeb Chrome overall, unable to load (on main too)

Web

desktopweb.mp4

Mobile Web - Chrome

Mobile Web - Safari

Safari.mp4

Desktop

desktop.mp4

iOS

IOS.mp4

Android

android.mp4

melvin-bot · 2023-07-11T20:25:42Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav

Change looks fine, testing this out.

melvin-bot · 2023-07-12T15:40:38Z

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-07-12T16:16:35Z

@dangrous I can see an issue related to [Deleted Message] visibility. do we want to tackle it here itself?

Steps:

Go to any chat, and send a message
Click on Reply to thread for the sent message (it should open the thread screen)
Do not enter any message and click on the header (From ...) to open the original chat
Delete the last sent message, and you'll see [Deleted Message] momentarily.

Here's the video with the applied steps.

deleted-thread-message.mov

Also after refreshing/logging out and logging in I can see these [Deleted Message] messages back.

dangrous · 2023-07-12T18:06:22Z

Hmmm @mananjadhav yeah that first issue seems like something we can tackle here as well. I think we just need to update the optimistic data to match, let me see what I can do.

As for the second you called out, I'm not seeing that, is there a specific circumstance that made that happen (e.g. slow connection, something like that?). If you inspect those with react dev tools, what are the values of isDeletedParentAction and childVisibleActionCount?

dangrous · 2023-07-12T18:26:38Z

I added a change that seems to fix that other issue, using hasCommentThread. Seems to work on my end, let me know how it tests!

Also after refreshing/logging out and logging in I can see these [Deleted Message] messages back.

@mananjadhav I managed to see the behavior you're talking about - but it only happens when I revert the code in this PR... Is it possible you didn't have the branch loaded when you were testing out that other issue?

mananjadhav · 2023-07-12T18:33:24Z

You're right. I think I had switched my branch by then. I'll retest the feature in your branch.

mananjadhav · 2023-07-12T18:46:09Z

@dangrous one more scenario, assume before we delete the last message, we copy the thread chat URL, and after deleting the last message we paste and visit the thread URL. At the moment, it loads [Deleted Message] chat window. I think this is fine for the expected behavior right? or should it redirect to the parent chat?

dangrous · 2023-07-12T18:54:07Z

@dangrous one more scenario, assume before we delete the last message, we copy the thread chat URL, and after deleting the last message we paste and visit the thread URL. At the moment, it loads [Deleted Message] chat window. I think this is fine for the expected behavior right? or should it redirect to the parent chat?

Hmmm yeah I think that's probably fine. That way, if there was an old URL somewhere, you'd know what happened (oh, the thread has been deleted) vs. just being redirected without a note. Technically then you could reopen a thread on a deleted message that you otherwise can't see, but I don't see how that would be used, for good or for bad.

melvin-bot · 2023-07-12T19:39:12Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-07-12T19:47:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-deleted-message.mov

Mobile Web - Chrome

mweb-chrome-deleted-message.mov

Mobile Web - Safari

mweb-safari-deleted-message.mov

Desktop

desktop-deleted-message.mov

iOS

ios-deleted-message.mov

Android

android-deleted-message.mov

Thanks for the answers @dangrous. Can you rerun the lint action? It looks failed. @yuwenmemon All yours.

dangrous · 2023-07-12T19:52:47Z

Yeah lint is not happy - seems like it's not just this PR, discussing here

dangrous · 2023-07-12T21:33:16Z

woo lint is good to go

srikarparsi

lgtm!

dangrous · 2023-07-13T16:14:01Z

So I think Melvin double-assigned an internal reviewer here, I don't think we need you @yuwenmemon but if you'd like to join in, have at it!

srikarparsi · 2023-07-13T19:16:18Z

Cool! I'll just go ahead and merge this since it seems pretty straightforward

OSBotify · 2023-07-13T19:20:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-14T15:01:20Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:39:05Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:40:08Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:04:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:01:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2023-07-27T14:19:12Z

src/libs/ReportActionsUtils.js

@@ -90,7 +90,7 @@ function isReportPreviewAction(reportAction) {
 * @returns {Boolean}
 */
 function hasCommentThread(reportAction) {
-    return lodashGet(reportAction, 'childType', '') === CONST.REPORT.TYPE.CHAT;
+    return lodashGet(reportAction, 'childType', '') === CONST.REPORT.TYPE.CHAT && lodashGet(reportAction, 'childVisibleActionCount', 0) > 0;


@dangrous I think this change is one level depth, It doesn’t check for nested threads, and that may lead to detached threads. For example :

Create Root Thread inside the parent report

Open Root Thread and create another thread inside it Thread 1

Open Thread 1 and create another thread inside it Thread 2

Go back to Root Thread and delete it and delete Thread 1

The thread is removed from the parent report even when we have nested thread

Now you can open Thread 2 and if you try to navigate the root thread it will navigate through all the deleted threads until you reach the parent thread.

Hm, that's interesting. Can you bring this up in Slack? It's probably not ideal behavior but I honestly can't think of what would be better. Like we'd still want to be able to access that content, so maybe it's fine? Do you think we should keep [Deleted message] all the way down until there's a real thread? It seems a bit confusing.

fedirjh · 2023-09-23T19:12:42Z

This PR caused a little regression in #23139 , more context in #23139 (comment)

only show threads with children

2a469b0

dangrous requested a review from a team as a code owner July 11, 2023 20:25

dangrous self-assigned this Jul 11, 2023

melvin-bot bot requested review from mananjadhav and removed request for a team July 11, 2023 20:25

hoangzinh mentioned this pull request Jul 12, 2023

[HOLD for payment 2023-07-24] [$1000] Web - [Deleted message] shows even if there is no thread #22674

Closed

6 tasks

mananjadhav approved these changes Jul 12, 2023

View reviewed changes

melvin-bot bot requested a review from yuwenmemon July 12, 2023 15:40

fix optimistic data too

1a90817

Merge branch 'main' into dangrous-fullyremovedeletedparentsifnothread

d319304

mananjadhav approved these changes Jul 12, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi July 12, 2023 19:39

Merge branch 'main' into dangrous-fullyremovedeletedparentsifnothread

823bb04

srikarparsi approved these changes Jul 12, 2023

View reviewed changes

srikarparsi merged commit 3948833 into main Jul 13, 2023
10 checks passed

srikarparsi deleted the dangrous-fullyremovedeletedparentsifnothread branch July 13, 2023 19:16

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

melvin-bot bot mentioned this pull request Jul 17, 2023

[HOLD for payment 2023-07-24] [$1000] The behavior of the delete message function in the workspace's announce room is not consistent. #21508

Closed

6 tasks

jigartankhupp mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-09-20] [$1000] Temporary thread message disappearance when deleting a thread message #23139

Closed

6 tasks

fedirjh mentioned this pull request Jul 20, 2023

[HOLD for payment 2023-08-10] [$1000] Mweb - "Deleted message" chat appears in chat list for pinned deleted threads #22950

Closed

6 tasks

fedirjh reviewed Jul 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

If a deleted parent doesn't have a thread anymore, hide it #22690

If a deleted parent doesn't have a thread anymore, hide it #22690

dangrous commented Jul 11, 2023 •

edited

Loading

melvin-bot bot commented Jul 11, 2023

mananjadhav left a comment

melvin-bot bot commented Jul 12, 2023

mananjadhav commented Jul 12, 2023 •

edited

Loading

dangrous commented Jul 12, 2023

dangrous commented Jul 12, 2023 •

edited

Loading

mananjadhav commented Jul 12, 2023

mananjadhav commented Jul 12, 2023 •

edited

Loading

dangrous commented Jul 12, 2023

melvin-bot bot commented Jul 12, 2023

mananjadhav commented Jul 12, 2023

dangrous commented Jul 12, 2023

dangrous commented Jul 12, 2023

srikarparsi left a comment

dangrous commented Jul 13, 2023

srikarparsi commented Jul 13, 2023

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

fedirjh Jul 27, 2023

dangrous Jul 27, 2023

fedirjh commented Sep 23, 2023

If a deleted parent doesn't have a thread anymore, hide it #22690

If a deleted parent doesn't have a thread anymore, hide it #22690

Conversation

dangrous commented Jul 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 11, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 12, 2023

mananjadhav commented Jul 12, 2023 • edited Loading

dangrous commented Jul 12, 2023

dangrous commented Jul 12, 2023 • edited Loading

mananjadhav commented Jul 12, 2023

mananjadhav commented Jul 12, 2023 • edited Loading

dangrous commented Jul 12, 2023

melvin-bot bot commented Jul 12, 2023

mananjadhav commented Jul 12, 2023

Reviewer Checklist

Screenshots/Videos

dangrous commented Jul 12, 2023

dangrous commented Jul 12, 2023

srikarparsi left a comment

Choose a reason for hiding this comment

dangrous commented Jul 13, 2023

srikarparsi commented Jul 13, 2023

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

fedirjh Jul 27, 2023

Choose a reason for hiding this comment

dangrous Jul 27, 2023

Choose a reason for hiding this comment

fedirjh commented Sep 23, 2023

dangrous commented Jul 11, 2023 •

edited

Loading

mananjadhav commented Jul 12, 2023 •

edited

Loading

dangrous commented Jul 12, 2023 •

edited

Loading

mananjadhav commented Jul 12, 2023 •

edited

Loading