-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reopenIssueWithComment GitHub Action #2163
Conversation
3e25c14
to
08a400e
Compare
Updated to address @roryabraham's comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I had a few organizational suggestions but all were pretty subjective so no blockers from me!
.github/actions/reopenIssueWithComment/reopenIssueWithComment.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few nabs/questions
.github/actions/reopenIssueWithComment/reopenIssueWithComment.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make a compromise in order to not kill all the tests with process.exit(0)
nor get errors by return;
-ing without a check.
Updated to address new comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Updated to address Joe's comment; added new test case for when there are no comments on an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Going to hold off on merging this today, because I want to run a production deploy and I don't want to introduce any new variables that might make it not work. This PR looks good, but I am 🐔 and don't want to test my luck until after we get all these PRs deployed. |
PullerBear chooses: @Jag96
cc @roryabraham @AndrewGable
Details
This PR adds two GitHub Actions:
checkDeployBlockers
andreopenWithComment
. The former evaluates recently closed issues, checking whether they have theStagingDeployCash
label, and if they do, checks the issue description for open markdown checkboxes (- [ ]
) and whether the last comment is missing the:shipit:
string. If either is true, the latter action is run which reopens the issue and leaves a comment.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/155248Tests
I mirrored all this logic in a personal test repo and verified that it worked. I did the following:
:shipit:
and close the issue gainUnit Tests
tests/unit/checkDeployBlockersTest.js