Return early if no issues found; add test for case

Expensify · Apr 7, 2021 · f0ccf58 · f0ccf58
1 parent 4d6576d
commit f0ccf58
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 10 deletions.
diff --git a/.github/actions/checkDeployBlockers/checkDeployBlockers.js b/.github/actions/checkDeployBlockers/checkDeployBlockers.js
@@ -31,17 +31,26 @@ const run = function () {
             });
         })
         .then((issues) => {
-            if (!_.isUndefined(issues)) {
-                console.log('Verifying that the last comment is :shipit:');
-                const lastComment = issues.data[issues.data.length - 1];
-                const shipItRegex = /^:shipit:/g;
-                if (_.isNull(shipItRegex.exec(lastComment.body))) {
-                    core.setOutput('HAS_DEPLOY_BLOCKERS', true);
-                    console.log('The last comment on the issue was not :shipit');
-                    return;
-                }
+            if (_.isUndefined(issues)) {
+                return;
+            }
+
+            if (_.isEmpty(issues.data)) {
+                console.log('No comments found on issue');
+                core.setOutput('HAS_DEPLOY_BLOCKERS', true);
+                return;
+            }
+
+            console.log('Verifying that the last comment is :shipit:');
+            const lastComment = issues.data[issues.data.length - 1];
+            const shipItRegex = /^:shipit:/g;
+            if (_.isNull(shipItRegex.exec(lastComment.body))) {
+                console.log('The last comment on the issue was not :shipit');
+                core.setOutput('HAS_DEPLOY_BLOCKERS', true);
+            } else {
+                console.log('Everything looks good, there are no deploy blockers!');
+                core.setOutput('HAS_DEPLOY_BLOCKERS', false);
             }
-            core.setOutput('HAS_DEPLOY_BLOCKERS', false);
         })
         .catch((error) => {
             console.error('A problem occurred while trying to communicate with the GitHub API', error);

diff --git a/tests/unit/checkDeployBlockersTest.js b/tests/unit/checkDeployBlockersTest.js
@@ -101,5 +101,12 @@ describe('checkDeployBlockers', () => {
                 expect(mockSetOutput).toHaveBeenCalledWith('HAS_DEPLOY_BLOCKERS', true);
             });
         });
+        test('Test an issue with all boxes checked but no comments', () => {
+            mockGetIssue.mockResolvedValue(baseIssue);
+            mockListComments.mockResolvedValue({data: []});
+            return run().then(() => {
+                expect(mockSetOutput).toHaveBeenCalledWith('HAS_DEPLOY_BLOCKERS', true);
+            });
+        });
     });
 });