[$250] [Waiting for payment - 2024-10-06] iOS - Login - White screen persists for some time after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Log in with an account with many reports

Expected Result:

There will be no white screen after login

Actual Result:

White screen persists for some time after login
On production, there is white screen but it appears very briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6617803_1727467446758.ScreenRecording_09-28-2024_04-00-21_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840741226805286590
• Upwork Job ID: 1840741226805286590
• Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[roryabraham]

Going to venture a guess that this is a front-end blocker, not a back-end blocker

[Julesssss]

This doesn't occur every time on my account, but I can reproduce on 9.0.41.1 and 9.0.41.0.Not 9.0.40.6. however

There are a lot of issues in the checklist. I'm working through them but in the meantime have asked for thoughts in Slack.

[truph01]

Edited by proposal-police: This proposal was edited at 2024-09-30 11:07:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

White screen persists for some time after login

What is the root cause of that problem?

• Come from PR.
• We return null when the data is loading:

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 401 to 402 in 8636074

	if (isLoadingOnyxValue(sessionStatus, lastOpenedPublicRoomIDStatus, initialLastUpdateIDAppliedToClientStatus)) {
	return;

What changes do you think we should make in order to solve the problem?

• We should return <FullScreenLoadingIndicator /> instead. (Or another loading screen based on design)

What alternative solutions did you explore? (Optional)

[truph01]

Proposal updated

[Julesssss]

Thanks @truph01. As this is a blocker I'm testing your proposal here.

[Nodebrute]

@Julesssss Reverting #49185 also fixes this issue

[Julesssss]

#49185

Yeah, in this case a simple fix might be preferable.

[allgandalf]

@truph01 's solution seems good actually, @truph01 have you tested it though ?

Seems to be working

[Julesssss]

Yeah, I'm fixing it here.

@truph01 we'll payout 50% for locating the regression.

[Julesssss]

Let's revert to speed things up. We can settle on the fix when re-submitting the PR.

@allgandalf will review

[truph01]

@truph01 we'll payout 50%

Thanks @Julesssss

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021840741226805286590

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[Nomanahmeda789]

The full screen loader have some issue.

[blazejkustra]

The revert doesn't fully fix the bug, when the internet speed is really bad you can still reproduce the bug, for a brief second white screen is shown after logging in:

Screen.Recording.2024-09-30.at.15.39.59.mov

[Julesssss]

The revert doesn't fully fix the bug, when the internet speed is really bad you can still reproduce the bug

Thanks for sharing. It's far more noticeable, though, after these changes. With a medium-large sized the issue is not seen once reverting the changes.

[Julesssss]

PR that made this blocker noticable has been reverted, deploy blocker label removed.

[blazejkustra]

@Julesssss Reverting it was the right call, but I think we still need to investigate why the white screen is displayed 🤔

[Julesssss]

Yes of course. I'll create a new issue for that, as it shouldn't be treated as a prior blocker.

[Julesssss]

Created this issue to figure out the cause of the blank page issue.

[melvin-bot]

@Julesssss, @allgandalf, @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

Lets close this !?

[truph01]

@Julesssss Sorry, do I and @allgandalf have payment based on comment?

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

@allgandalf were you paid yet? I think probably not right?

@JmillsExpensify could you please pay out the following once this has been confirmed? Thanks

• @truph01 $125 for locating blocker (50%)
• @allgandalf $250 for review of revert PR

[johncschuster]

Looks like @allgandalf needs to be paid out via Upwork for the review. I'm taking care of that in this issue.

[allgandalf]

Yeah, that is why i asked to close this issue 😄

[Julesssss]

Oh right.

@johncschuster would you mind taking care of the other payment there too?

@truph01 $125 for locating blocker (50%)