Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Update payment section with bank icon #45950

Closed
tgolen opened this issue Jul 22, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Task

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @Guccio163
@JmillsExpensify
Copy link

@Guccio163 Will you work on this issue as well?

@Guccio163
Copy link
Contributor

Hey I'm Wiktor Gut from Software Mansion, yes I'll handle it as well so please assign it to me!

Guccio163 added a commit to software-mansion-labs/expensify-app-fork that referenced this issue Jul 26, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 26, 2024
tgolen added a commit that referenced this issue Jul 30, 2024
…divide_workflows

#45949 & #45950 Divide workflows page into three sections & Update payment section with bank icon
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 2, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] [Advanced Approval Workflows] Update payment section with bank icon [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Update payment section with bank icon Aug 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

  • @Guccio163 does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Aug 13, 2024

@tgolen, @Guccio163 Huh... This is 4 days overdue. Who can take care of this?

@Guccio163
Copy link
Contributor

I guess we can close it since it was resolved together with #45949 :)

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@tgolen, @Guccio163 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

@tgolen, @Guccio163 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Aug 23, 2024

@tgolen, @Guccio163 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Aug 27, 2024

@tgolen, @Guccio163 12 days overdue now... This issue's end is nigh!

@tgolen
Copy link
Contributor Author

tgolen commented Aug 30, 2024

Closing this out.

@tgolen tgolen closed this as completed Aug 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Task
Projects
None yet
Development

No branches or pull requests

3 participants