Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Divide workflows page into three sections #45949

Closed
tgolen opened this issue Jul 22, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Task

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @Guccio163
@Guccio163
Copy link
Contributor

Hi! I'm Wiktor Gut from Software Mansion, an expert agency, I talked with @blazejkustra and I'd like to work on this issue!

Guccio163 added a commit to software-mansion-labs/expensify-app-fork that referenced this issue Jul 26, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 26, 2024
@jayeshmangwani
Copy link
Contributor

@tgolen I have been assigned to the PR for this issue. May I get access to the document please?

@tgolen
Copy link
Contributor Author

tgolen commented Jul 29, 2024

Sure! Can you let me know what email address I can share it with?

@jayeshmangwani
Copy link
Contributor

Sure! Can you let me know what email address I can share it with?

jayeshmangwani@gmail.com

@tgolen
Copy link
Contributor Author

tgolen commented Jul 29, 2024

OK, shared!

tgolen added a commit that referenced this issue Jul 30, 2024
…divide_workflows

#45949 & #45950 Divide workflows page into three sections & Update payment section with bank icon
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 2, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] [Advanced Approval Workflows] Divide workflows page into three sections [HOLD for payment 2024-08-09] [CRITICAL] [Advanced Approval Workflows] Divide workflows page into three sections Aug 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

  • @Guccio163 does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@jayeshmangwani
Copy link
Contributor

@tgolen Can you please assign me to this issue and also assign a BZ member to add the payment summary?

@tgolen tgolen added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@tgolen
Copy link
Contributor Author

tgolen commented Aug 12, 2024

@Christinadobrzyn Could you please help pay @jayeshmangwani for a C+ review of the PR?

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 12, 2024

Yes! Payouts due:

@jayeshmangwani can you please submit a payment request? Thank you!

@jayeshmangwani
Copy link
Contributor

Hi @Christinadobrzyn, I am receiving payment from NewDot.

@Christinadobrzyn
Copy link
Contributor

Perfect! Thanks @jayeshmangwani - I think this is good to close unless we should have a regression test?

@jayeshmangwani
Copy link
Contributor

we should have a regression test?

I don't think we need a regression test here since it's just a feature enhancement.

@Christinadobrzyn
Copy link
Contributor

Sounds good! Closing this!

@jayeshmangwani
Copy link
Contributor

Requested on ND as per #45949 (comment)

@JmillsExpensify
Copy link

$250 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Task
Projects
None yet
Development

No branches or pull requests

5 participants