[HOLD for payment 2024-07-24] [Closed & Archived] Pass in ReportNameValuePairs to isArchived

[srikarparsi]

Background:

We're changing how we detect if a report is archived. Before, we were using the report's state and status which are in the report onyx collection. Now, we want to use a report's isArchived property which is in the reportNameValuePairs onyx collection.

Request:

We need to pass in reportNameValuePairs wherever isArchivedRoom is called. This has already been done for the ReportFooter which can be used as an example. (Look at ReportScreen.tsx and ReportFooter.tsx changes).

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[srikarparsi]

We're on a pretty tight timeline so please only post a proposal if you're able to work on a PR today. This should be a relatively straightforward change but please ask if there's any questions.

[DylanDylann]

@srikarparsi It is so straightforward. I can work on the PR now

🎀👀🎀

[melvin-bot]

Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pass in ReportNameValuePairs to isArchived.

What is the root cause of that problem?

New change.

What changes do you think we should make in order to solve the problem?

Just pass reportNameValuePairs to isArchivedRoom as the second param.

I'm available to open a PR quickly.

[srikarparsi]

Awesome, that would be great, thanks @DylanDylann

[srikarparsi]

@Pujan92, sorry for the assignment, I can review this PR when @DylanDylann creates it. Do you have an ETA @DylanDylann?

[DylanDylann]

Give me 2 hours for both implementation and testing

[srikarparsi]

Cool, two things for testing.

1. The Onyx key is named private_isArchived but in App it's currently called isArchived. So to test, you will need to use private_isArchived. I created a PR here to change the variable name but there's one problem so once that's figured out, we can switch all occurrences to either isArchived or private_isArchived.

2. The backend isn't fully complete so there may be some cases where you don't get the private_isArchived onyx update inside the reportNameValuePairs collection. One way that will reliably work is creating a workspace and then deleting it. You should see the private_isArchived key for all the newly archived workspace chats which you can use to test.

[DylanDylann]

The backend isn't fully complete so there may be some cases

@srikarparsi Should we keep the report's state and status condition in isArchivedRoom function. IMO, we can remove the report's state and status if BE fully complete, but now I think we still need to keep the report's state and status condition

[srikarparsi]

Yes, let's keep it there for now as a fallback.

[DylanDylann]

Please give me one more hour. There are many places that need to be updated

[DylanDylann]

@srikarparsi The PR is ready for review

[dylanexpensify]

Woot!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• using report name value to check archived #45330

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@DylanDylann] Determine if we should create a regression test for this bug.
• [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment coming up!

[dylanexpensify]

Payment summary:

• Contributor: @DylanDylann $250

Please request/apply!

[dylanexpensify]

Job post: https://www.upwork.com/jobs/~0158d0455594dee8e1

[suneox]

Hi @dylanexpensify

I have reviewed the PR and reviewer checklist so can I have any compensation?

[DylanDylann]

Thanks @dylanexpensify I applied to the job post 👍

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dylanexpensify]

@suneox please apply to!

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

@puneetlath I'm heading OOO now until 5th of August! Waiting for @suneox to apply and @DylanDylann to accept! TY! I owe ya one!

[suneox]

@suneox please apply to!

Hi @dylanexpensify I have applied this job https://www.upwork.com/jobs/~0158d0455594dee8e1

[puneetlath]

@suneox can you complete the checklist?

Offers are out to @suneox and @DylanDylann. Waiting for both to accept. Please ping me on this issue when you have.

[suneox]

@suneox can you complete the checklist?

Offers are out to @suneox and @DylanDylann. Waiting for both to accept. Please ping me on this issue when you have.

@puneetlath Thank you, I have accepted an offer and I will complete the zero checklist in few hours

[suneox]

BugZero Checklist:

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A: This is a new approach to detect if a report is archived.
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug. N/A

[puneetlath]

Great thanks. @suneox has been paid.

@DylanDylann please ping me here when you've accepted the contract and we can close this out.

[DylanDylann]

@DylanDylann please ping me here when you've accepted the contract

@puneetlath I did, thanks 🙏

[puneetlath]

All paid. Thanks everyone!