[HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] Group chat - App crashes when navigating to group details page after creating the group

[izarutskaya]

• If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to FAB > Start chat > Chat.
4. Select a few users.
5. Create a group chat.
6. Click on the report header.
7. Click Name.
8. Go online.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543532_1721111757102.20240716_143148.mp4

Bug6543532_1721111757091!staging.new.expensify.com-1721111532581.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[melvin-bot]

Current assignee @puneetlath is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes.

What is the root cause of that problem?

When we create a group chat, the parentReportID is an empty string and then after we go back online BE returns parentReportID of the report as null. The app crashes because the key is changed from collection key to collection member key

App/src/pages/ReportDetailsPage.tsx

Line 90 in 1465a92

const [parentReportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.parentReportID ?? -1}`);

What changes do you think we should make in order to solve the problem?

Use || instead of ?? here

App/src/pages/ReportDetailsPage.tsx

Lines 89 to 90 in 1465a92

	const [reportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? -1}`);
	const [parentReportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.parentReportID ?? -1}`);

What alternative solutions did you explore? (Optional)

Or when we create the optimistic data for the chat, add parentReportID field as null or -1 instead of empty string,

[puneetlath]

@nkdengineer do you know what PR introduced this issue?

[nkdengineer]

@puneetlath I think it comes from #45330.

[puneetlath]

Ok gotcha. @srikarparsi do you see any issues with @nkdengineer's proposed fix?

[srikarparsi]

I personally think the alternate solution is better. I think we should do that regardless of whether or not we implement the main solution. @nkdengineer is there a reason you prefer the main solution over the alternate, and is there a reason you would still want to implement the main solution on top of the alternate?

[chiragsalian]

Removing deployblocker label from this issue since I'm pretty sure the issue here is not related to web-E/backend.

[puneetlath]

Ok let's go with @nkdengineer's alternate proposal. Can you raise a PR ASAP @nkdengineer?

[puneetlath]

I raised the PR but we will still compensate you @nkdengineer

[kavimuru]

@puneetlath able to reproduce on 9.0.7-6

az_recorder_20240717_030232.mp4

[srikarparsi]

I can take a look at this

[thienlnam]

Hmm, I tested this on staging before kicking off the deploy but I must have not followed the steps correctly - my bad, but it should be okay if we can get another fix CPed before the next deploy since this has to do with offline flows

[srikarparsi]

Yup, on it. It'll take me like 10-15 minutes probably if that's okay?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Pass -1 as default parent reportID for group chats #45533

If no regressions arise, payment will be issued on 2024-07-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath] Determine if we should create a regression test for this bug.
• [@puneetlath] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[nkdengineer]

Ok let's go with @nkdengineer's alternate proposal. Can you raise a PR ASAP @nkdengineer?

It's too late in my time zone.

I raised the PR but we will still compensate you @nkdengineer

@puneetlath Thanks. Can you please assign me here for payment?

[kavimuru]

Bug is fixed.

1721196566724.45542_iOS.mp4

[puneetlath]

@nkdengineer sent you an offer. Ping me here when you've accepted. https://www.upwork.com/nx/wm/offer/103157107

[nkdengineer]

@puneetlath I accepted, thanks 🙇

[puneetlath]

Paid thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Pass -1 as default parent reportID for group chats #45533
• Fix group chat crash #45542

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@nkdengineer] Determine if we should create a regression test for this bug.
• [@nkdengineer] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: