Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-05] [Search v2.1] [App] Use new query syntax #45027

Closed
1 task done
luacmartins opened this issue Jul 8, 2024 · 15 comments
Closed
1 task done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 8, 2024

Implement this section of the design doc.

Holding on:

cc @adamgrzybowski @Kicu @WojtekBoman

Issue OwnerCurrent Issue Owner: @adelekennedy
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024
@luacmartins luacmartins self-assigned this Jul 8, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 8, 2024
@luacmartins luacmartins changed the title [Search v2] [App] Use new query syntax [HOLD 45025] [Search v2] [App] Use new query syntax Jul 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2024
@adelekennedy
Copy link

still on hold here

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2024
@luacmartins luacmartins changed the title [HOLD 45025] [Search v2] [App] Use new query syntax [Search v2] [App] Use new query syntax Jul 11, 2024
@luacmartins
Copy link
Contributor Author

Ready to be worked on!

@adamgrzybowski
Copy link
Contributor

@luacmartins Looks like something for me!

Copy link

melvin-bot bot commented Jul 15, 2024

@luacmartins, @adelekennedy, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@adamgrzybowski
Copy link
Contributor

I'm actively working on this one

@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 17, 2024
@adamgrzybowski
Copy link
Contributor

The draft is here #45617. I hope to finish it tomorrow

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 19, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 24, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 29, 2024
@melvin-bot melvin-bot bot changed the title [Search v2] [App] Use new query syntax [HOLD for payment 2024-08-05] [Search v2] [App] Use new query syntax Jul 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@luacmartins luacmartins changed the title [HOLD for payment 2024-08-05] [Search v2] [App] Use new query syntax [HOLD for payment 2024-08-05] [Search v2.1] [App] Use new query syntax Jul 31, 2024
@rayane-djouah
Copy link
Contributor

No need for regression test steps for now; they will be added as part of the project.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 5, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@adelekennedy)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@adelekennedy
Copy link

@rayane-djouah
Copy link
Contributor

@adelekennedy - Offer accepted, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

5 participants