Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [Search v2] [App] Create getFilters #45025

Closed
1 task
luacmartins opened this issue Jul 8, 2024 · 7 comments
Closed
1 task

[HOLD for payment 2024-07-24] [Search v2] [App] Create getFilters #45025

luacmartins opened this issue Jul 8, 2024 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 8, 2024

Implement this section of the design doc.

Holding on:

cc @adamgrzybowski @Kicu @WojtekBoman

Issue OwnerCurrent Issue Owner: @RachCHopkins
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Jul 8, 2024
@luacmartins luacmartins self-assigned this Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @RachCHopkins (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Jul 8, 2024
@luacmartins luacmartins changed the title [Search v2] [App] Create getQueryParams [HOLD #45024] [Search v2] [App] Create getQueryParams Jul 8, 2024
@luacmartins luacmartins changed the title [HOLD #45024] [Search v2] [App] Create getQueryParams [HOLD #45024] [Search v2] [App] Create getFilters Jul 9, 2024
@luacmartins
Copy link
Contributor Author

I'll work on this one and base my branch off of #45161.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024
@luacmartins luacmartins changed the title [HOLD #45024] [Search v2] [App] Create getFilters [Search v2] [App] Create getFilters Jul 11, 2024
@luacmartins
Copy link
Contributor Author

PR in review

@luacmartins
Copy link
Contributor Author

We can close this. It was all handled internally.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [Search v2] [App] Create getFilters [HOLD for payment 2024-07-24] [Search v2] [App] Create getFilters Jul 17, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

2 participants