Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v2.1][Auth] Deprecate old syntax code #45030

Closed
1 task done
luacmartins opened this issue Jul 8, 2024 · 12 comments
Closed
1 task done

[Search v2.1][Auth] Deprecate old syntax code #45030

luacmartins opened this issue Jul 8, 2024 · 12 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 8, 2024

Implement this section of the design doc.

Holding on:

@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024
@luacmartins luacmartins self-assigned this Jul 8, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 8, 2024

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2024
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Jul 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2024
@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@luacmartins
Copy link
Contributor Author

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 23, 2024
@JmillsExpensify
Copy link

Can we remove the hold now?

@luacmartins luacmartins changed the title [HOLD 45027][Search v2][Auth] Deprecate old syntax code [HOLD 46481][Search v2][Auth] Deprecate old syntax code Jul 30, 2024
@luacmartins
Copy link
Contributor Author

Not yet, the holding PR is still in draft. Also, this is just clean up work, so I think it's lower priority than the remaining filters.

@luacmartins luacmartins changed the title [HOLD 46481][Search v2][Auth] Deprecate old syntax code [HOLD 46481][Search v2.1][Auth] Deprecate old syntax code Jul 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
@zanyrenney
Copy link
Contributor

Are we able to remove the hold yet? I can't see the linked PR.

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2024
@zanyrenney
Copy link
Contributor

cc @luacmartins

@luacmartins
Copy link
Contributor Author

Not yet

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@zanyrenney
Copy link
Contributor

Looks like the PR is merged, good to remove the hold @luacmartins ?

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@luacmartins luacmartins changed the title [HOLD 46481][Search v2.1][Auth] Deprecate old syntax code [Search v2.1][Auth] Deprecate old syntax code Aug 20, 2024
@luacmartins
Copy link
Contributor Author

Yea, hold removed. Thanks!

@luacmartins luacmartins added the Reviewing Has a PR in review label Aug 23, 2024
@luacmartins
Copy link
Contributor Author

@zanyrenney this is all internal work, so I'll unassign you.

@luacmartins
Copy link
Contributor Author

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants