[$250] Scan - "Only visible to you" whisper is not visible on multiple request report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.74-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4561920
Email or phone of affected tester (no customers): dave0123seife+employe16a@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to the workspace chat as the employee
2. Submit a request using a scan
3. While it is Scanning, There's a whisper message on top of the request "Only visible to you" (this might take a few sec to show up)
4. Submit a manual request.
5. Because we have not submitted the requests, Notice both requests are in one request conversation,
6. Notice that there is no whisper message on top of the request "Only visible to you"

Expected Result:

"Only visible to you" whisper is visible on multiple request report

Actual Result:

"Only visible to you" whisper is not visible on multiple request report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6482265_1715826847238.Only_visible_to_You_issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba739091862c309e
• Upwork Job ID: 1791487887666659328
• Last Price Increase: 2024-05-17

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[Beamanator]

haven't been able to look at this, site has been down recently and fixed other blockers earlier 😅

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba739091862c309e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[Beamanator]

I'm pretty sure this can be worked externally - Also we won't deploy today so we have a bit more time to get external help

[CortneyOfstad]

Sounds good @Beamanator — does this still need to remain hourly or can I adjust this to daily?

[ishpaul777]

Hey! This is not a bug, "only visible to you" message on whisper is removed intentionaly in this PR #40020 (comment)

[hungvu193]

So I think we can close it then?

[Beamanator]

Oofda quite interesting!! @ishpaul777 @yuwenmemon In this issue OP's video, it looks like we show the "Only visible to you" when smart scanning a receipt, but when we do a manual request & the expense previews are combined, we do NOT show "Only visible to you" - is that intentional?

From @ishpaul777 's comment here, it sounds like we're trying to remove the "Only visible to you" message... Maybe everywhere?

[hungvu193]

Cool. I also think this is intentional

[Beamanator]

For now I'll at least make this NAB 👍

[ishpaul777]

it sounds like we're trying to remove the "Only visible to you" message... Maybe everywhere?

Not everywhere just for the smartscan previews #40020 (comment)

[Beamanator]

aah ya sorry that's what i meant @ishpaul777 - i meant "it looks like we're trying to remove the "Only visible to you" message for ALL smartscan previews" -> The reason I'm mentioning that, is that this issue is mainly about "multiple-request report previews" but I think it could be generalized

[ishpaul777]

I think there's still a issue that it shows the message after a while for single smartscan, i think we should fix this but not as a blocker

Screen.Recording.2024-05-21.at.3.01.48.PM.mov

[Beamanator]

Yeah exactly, that makes sense to me too - so IFF we should be getting rid of that, I think we should make a new issue OR at the least bit, completely clean up this issue OP & title 😅

[ishpaul777]

Title: Scan - "Only visible to you" whisper is visible on single scan request report

1. Navigate to the workspace chat as the employee
2. Submit a request using a scan
3. Wait for few seconds.

Actual-

There's a whisper "Only visible to you" message on top of the request

Expected -

No whisper "Only visible to you" message on top of the request

[Beamanator]

cc @yuwenmemon , maybe even @Expensify/design - can y'all confirm if ^ is a bug?

[shawnborton]

@grgia can you confirm expected behavior here? My understanding is with the updated pending transactions project, we should never see the "only you can see this" whisper pattern with scanning expenses.

[grgia]

Yes this is expected as of right now, since we're removing whispers from scan. We're still waiting on this BE change to remove the whisper logic entirely, but we stopped showing it in the FE

[shawnborton]

Got it - thanks for confirming. Can you check the video in the bug report? It looks like maybe we missed a spot then?

[Beamanator]

Nice, thanks - yeah since it looks like we're missing one place, @grgia do you think we should work on that in this issue OR create a fresh one for that 1 spot? OR do you think the backend PRs should fix this? 🙏

[hungvu193]

little bump @grgia

[grgia]

@Beamanator the BE PR is removing whispers from pending/scanning receipts

[hungvu193]

@Beamanator I just want to clarify if this issue is treated as a regression, if yes please unassign me 😄

[Beamanator]

@grgia sorry but it's still not quite clear to me if the BE PR will fix the "bug" shown here - #42259 (comment) - that there is still 1 final place we DO show "Only visible to you" where we shouldn't.

If you can confirm that the BE PR will fix that, I think we're good to close this one out, yeah? 🙏

[hungvu193]

@grgia can you please confirm above comment?

[grgia]

@Beamanator we're removing whispers from all newly created pending/scanning transactions, so we shouldn't see "only visible to you" at all. We could remove it from the UI as part of this issue for existing transactions though. Does that answer your question?

[Beamanator]

Ahhhh the point is that the whisper already exists for old transactions, but shouldn't happen for new ones, eh?

We could remove it from the UI as part of this issue for existing transactions though.

Has this been discussed anywhere in the doc or other threads @grgia ? If not, maybe we should bring it up somewhere?

[grgia]

Yeah we can bring this up in slack, it honestly won't affect many reports since they are only pending or scanning for a day or two. I take it back on fixing it in this issue, I'm pretty sure we can close this one in favor of the BE changes @Beamanator. Happy to jump into a discussion in slack if there's still something that's uncertain here

[Beamanator]

Ok cool I'm also down with closing in favor of BE changes, let's go for it 👍