[HOLD for payment 2024-05-22] [Pending/Scanning pattern] Update the UI for Pending and Scanning in Single Transaction ReportPreview / MoneyRequestAction

[grgia]

Design Doc Section

https://docs.google.com/document/d/1hKK7emsQt4iDvP8Ohvk5aCc8gNdRelyxvbxDkXZxNRA/edit#bookmark=id.hpicdhh0ps4f

Goal

Use new UI pattern for both pending and scanning transactions.

Requirements

#38688 (comment)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db8df296aa6c0d99
• Upwork Job ID: 1770496519810551808
• Last Price Increase: 2024-03-20

Issue Owner

Current Issue Owner: @kevinksullivan

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01db8df296aa6c0d99

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Gonna give this one to you @dannymcclain

[dannymcclain]

Updated mocks. These can all be found here in Figma.

Pending Transaction

Receipt Scanning

"Report Status" Overview

@grgia let me know if you need anything else!

[grgia]

@dannymcclain are we removing the highlight row pattern?

[dannymcclain]

Yes, we decided in this thread to keep it simple to start and just go with the status pattern (no highlight).

[grgia]

Rad, that makes life easy! @dannymcclain.

cc @kevinksullivan shall we update the HL? I can make a few adjustments to the detailed before I pass off to SWM

[BrtqKr]

Hey, I'm an engineer from SWM, I'd like to handle this ticket

[grgia]

@BrtqKr let me know if there's anything you need for this one. I updated the design doc section to reflect the final design.

@dannymcclain I believe we'll need these two new icon assets for this issue:

[grgia]

@dannymcclain could you also show me a mock with the report previews for this flow?

By that I mean,

What does it look like on the ReportPreview (parent chat) when a report has:

• 1 scanning, 1 pending, 1 normal request
• 1 scanning, 1 normal request
• 1 pending, 1 normal request
• etc.

Are there any changes we need to make there? I believe right now it shows copy like 1 request, 1 scanning, 1 pending. I want to make sure we cover all bases here for QA, thanks!

[dannymcclain]

I believe we'll need these two new icon assets for this issue:

Oh wow I guess you're right! Here they are:

• Credit Card Hourglass.svg.zip
• Receipt Scan.svg.zip

Are there any changes we need to make there? I believe right now it shows copy like 1 request, 1 scanning, 1 pending. I want to make sure we cover all bases here for QA, thanks!

I don't think we're changing anything there. At least I wouldn't expect us to—happy to do some mocks for those situations but I'm not 100% sure what they look like/say and I don't want to create any confusion. Is not changing anything enough for you to go on? 😅 If not I can do some investigating.

[dannymcclain]

I need Melvin to leave me alone. Any important updates on this one?

[grgia]

bump @BrtqKr

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Pending/Scanning pattern] Update the UI for Pending and Scanning in Single Transaction ReportPreview / MoneyRequestAction #40020

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @BrtqKr does not require payment (Contractor)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ishpaul777]

False alert ⬆️

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @kevinksullivan you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @BrtqKr is from an agency-contributor and not due payment
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kevinksullivan)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1770496519810551808/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ishpaul777]

Friendly Bump @kevinksullivan : )

[melvin-bot]

@dannymcclain, @kevinksullivan, @grgia, @BrtqKr, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[grgia]

@kevinksullivan I think we just need C+ payment here

[melvin-bot]

@dannymcclain, @kevinksullivan, @grgia, @BrtqKr, @ishpaul777 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@dannymcclain, @kevinksullivan, @grgia, @BrtqKr, @ishpaul777 12 days overdue. Walking. Toward. The. Light...

[ishpaul777]

gentle bump @kevinksullivan

[kevinksullivan]

handling

[kevinksullivan]

job is expired so I am creating a new one. @ishpaul777 lmk when you accept

https://www.upwork.com/jobs/~011eaca59680ce2d2b

[kevinksullivan]

all set