[HOLD for payment 2024-04-09] [$500] Workspace - New Workspace button doesn't create WS and shows no default name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.53-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around https://expensify.testrail.io/index.php?/tests/view/4428235
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to NewDot and login
2. Click WS dropdown in the top of LHN
3. Click +
4. Change WS name and click Save
5. Click New Workspace button in the top right corner

Expected Result:

New WS created, default name should be displayed

Actual Result:

Default name is not displayed, and WS is not created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6415317_1710529817272.video_32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0171b0f044271b7cff
• Upwork Job ID: 1769593725439668224
• Last Price Increase: 2024-03-18
• Automatic offers:
• alitoshmatov | Reviewer | 0

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace lists page opens up when trying to update workspace name, currency etc after creating a new workspace.

What is the root cause of that problem?

We shouldn't be seeing the workspaces list when editing the newly created workspace name.

This logic is unnecessarily pushing the workspaces list page in the central pane.

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

	// When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane.
	// Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane.
	if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
	routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
	}

What changes do you think we should make in order to solve the problem?

There's no need of the above logic, we can simply remove it and it will solve the navigation issue. Same issue can be seen at multiple other places which will also get resolved.

This is same as my proposal here: #38436 (comment)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We have a logic added from #37421 Ideal Nav PR which sets the Central Pane to Workspace settings page

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 185 to 189 in e40fba1

	// When we open a screen in RHP from FullScreenNavigator, we need to add the appropriate screen in CentralPane.
	// Then, when we close FullScreenNavigator, we will be redirected to the correct page in CentralPane.
	if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
	routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
	}

This was done to address the condition where RHP was opened from FullScreenNavigator, to adjust to the correct page of central pane.

But over here we only consider the condition when RHP was opened from LHN and not the condition where RHP is opened from Central Pane.

What changes do you think we should make in order to solve the problem?

We need to consider an additional Condition to check if the RHP was opened from LHN and then only Set the Central Pane to workspace settings Page:

- if (matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) {
+ if ((matchingRootRoute.name === NAVIGATORS.FULL_SCREEN_NAVIGATOR) && isRHPScreenOpenedFromLHN) {
                routes.push(createCentralPaneNavigator({name: SCREENS.SETTINGS.WORKSPACES}));
            }          

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0171b0f044271b7cff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[ShridharGoel]

@GandalfGwaihir Do you have any example of a use-case where this would be needed?

[iammudassirali]

Hi there!

I've carefully reviewed the issue you've reported regarding the default workspace creation problem in the Expensify app. I understand the importance of maintaining a reliable and seamless user experience, especially when it comes to financial transactions.

To address this issue, I propose the following technical solution:

Investigation and Analysis:

I'll start by examining the codebase related to workspace creation in the Expensify app.
I'll identify any potential logic errors or misconfigurations that could be causing the default workspace name not to display.
Code Refactoring:

If necessary, I'll refactor the relevant code to ensure that the default workspace name is properly displayed.
This may involve debugging the existing code and making modifications to improve its functionality.
Testing and Validation:

Once the changes are implemented, I'll thoroughly test the workspace creation functionality across different environments, including staging and production.
I'll also perform regression testing to ensure that no new issues are introduced as a result of the changes.
Documentation and Reporting:

Throughout the process, I'll maintain detailed documentation of the steps taken and the changes made.
I'll provide clear reports on the findings, actions taken, and outcomes of the testing phase.
Collaboration and Communication:

I'll maintain open communication with the Expensify team, providing regular updates on the progress of the resolution process.
I'll actively seek feedback and collaborate with team members to ensure that the solution aligns with the project requirements.
I'm confident that my technical expertise and problem-solving skills make me well-suited to address this issue effectively. I'm committed to delivering a high-quality solution that meets the standards of reliability and user experience expected from the Expensify app.

I look forward to the opportunity to contribute to the success of the Expensify project. If you have any questions or need further clarification, please don't hesitate to reach out.

Best regards,
Mudassir Ali

P.S. I'm excited about the opportunity to work with the Expensify team and contribute to the ongoing improvement of the app! 😊

[melvin-bot]

📣 @iammudassirali! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[iammudassirali]

thisismudassirali@gmail.com
https://www.upwork.com/freelancers/~0191fe0bea01c9f099

[iammudassirali]

Contributor details
Email Address: thisismudassirali@gmail.com
Upwork Profile: https://www.upwork.com/freelancers/~0191fe0bea01c9f099

[iammudassirali]

Contributor details
Your Expensify account email: thisismudassirali@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0191fe0bea01c9f099

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[iammudassirali]

Hi there!

I've carefully reviewed the issue you've reported regarding the default workspace creation problem in the Expensify app. I understand the importance of maintaining a reliable and seamless user experience, especially when it comes to financial transactions.

To address this issue, I propose the following technical solution:

Investigation and Analysis:

I'll start by examining the codebase related to workspace creation in the Expensify app.
I'll identify any potential logic errors or misconfigurations that could be causing the default workspace name not to display.
Code Refactoring:

If necessary, I'll refactor the relevant code to ensure that the default workspace name is properly displayed.
This may involve debugging the existing code and making modifications to improve its functionality.
Testing and Validation:

Once the changes are implemented, I'll thoroughly test the workspace creation functionality across different environments, including staging and production.
I'll also perform regression testing to ensure that no new issues are introduced as a result of the changes.
Documentation and Reporting:

Throughout the process, I'll maintain detailed documentation of the steps taken and the changes made.
I'll provide clear reports on the findings, actions taken, and outcomes of the testing phase.
Collaboration and Communication:

I'll maintain open communication with the Expensify team, providing regular updates on the progress of the resolution process.
I'll actively seek feedback and collaborate with team members to ensure that the solution aligns with the project requirements.
I'm confident that my technical expertise and problem-solving skills make me well-suited to address this issue effectively. I'm committed to delivering a high-quality solution that meets the standards of reliability and user experience expected from the Expensify app.

I look forward to the opportunity to contribute to the success of the Expensify project. If you have any questions or need further clarification, please don't hesitate to reach out.

Best regards,
Mudassir Ali

P.S. I'm excited about the opportunity to work with the Expensify team and contribute to the ongoing improvement of the app! 😊

[allgandalf]

Welcome to Expensify open source @iammudassirali 👋 , here's the proposal template to follow while posting a proposal, also refer to contribution guidelines , thanks

[gieoon]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. The default workspace name is not defined when creating a workspace from WorkspaceSwitcherPage.tsx.
2. The workspace is not created or saved.

What is the root cause of that problem?

Workspace is being created from a policy draft rather than a policy. The current logic does not handle policy drafts and the name is undefined in WorkspaceProfilePage.

WorkspaceProfilePage does not accept policyDraft, so policy is undefined and the policyDraft is ignored.

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 44 in e737a63

function WorkspaceProfilePage({policy, currencyList = {}, route}: WorkSpaceProfilePageProps) {

The policy draft is also never saved, so App.savePolicyDraftByNewWorkspace(policyDraft.id, policyDraft.name, '', policyDraft.makeMeAdmin); needs to be called from somewhere.

What changes do you think we should make in order to solve the problem?

Policy needs to be inherited by WorkspaceProfilePage and handled in the logic when creating a policy.

function WorkspaceProfilePage({policyDraft, policy, currencyList = {}, route}: WorkSpaceProfilePageProps) {
      
      policy = policyDraft?.id ? policyDraft : policy;

}

App.savePolicyDraftByNewWorkspace also needs to be called from within useEffect in WorkspaceProfilePage.tsx as it is also done in WorkspaceInitialPage.tsx.

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 76 to 86 in e737a63

	useEffect(() => {
	const policyDraftId = policyDraft?.id;
	if (!policyDraftId) {
	return;
	}
	App.savePolicyDraftByNewWorkspace(policyDraft.id, policyDraft.name, '', policyDraft.makeMeAdmin);
	// We only care when the component renders the first time
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

Proposed solution in WorkspaceProfilePage.tsx

useEffect(() => {
        
        ...

        if ( policyDraft ) {
            App.savePolicyDraftByNewWorkspace(policyDraft.id, policyDraft.name, '', policyDraft.makeMeAdmin);
        }

        ...

    }, []);

What alternative solutions did you explore? (Optional)

Changing the props directly in the HOC withPolicy.tsx before they reach the React Component.

[melvin-bot]

📣 @gieoon! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kaushiktd]

@WojtekBoman Do you have any feedback for my proposal?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix opening FullScreenNavigator from the Home page #38734

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @alitoshmatov requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$500 to @alitoshmatov

[kadiealexander]

@alitoshmatov please don't forget about the checklist!

[kadiealexander]

Bumped @alitoshmatov here.

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav  #33280
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33280/files#r1561250597
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug. No need

[kadiealexander]

Payouts due:

• Contributor+: $500 @alitoshmatov

Upwork job is here.