[HOLD for payment 2024-02-19] [$500] IOU -Deleting submitted report shows unexpected error with amount crossed out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Login employee account
3. Tap on employee workspace chat
4. Tap plus icon near compose-- request money manual
5. Enter an amount and tap next
6. Enter merchant field
7. Tap request
8. Tap submit
9. Open submitted IOU to open IOU detail page
10. Tap 3 dots on top right and tap delete and confirm delete request

Expected Result:

User must not be shown option/allowed to delete submitted report & error should not be displayed with amount crossed out

Actual Result:

In employee WS, create manual request and submit it. User shown option/allowed to delete submitted report and deleted report shows unexpected error with amount crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343590_1705353673385.rep.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165e8908305facf78
• Upwork Job ID: 1747014776873512960
• Last Price Increase: 2024-01-22
• Automatic offers:
• s77rt | Reviewer | 28134406
• bernhardoj | Contributor | 28134407

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165e8908305facf78

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting a submitted money request gives an error.

What is the root cause of that problem?

We are not hiding the delete button when the money request is submitted. We only hide it if it's approved or settled.

App/src/components/MoneyRequestHeader.js

Line 88 in 8e2fb67

const canModifyRequest = isActionOwner && !isSettled && !isApproved && !ReportActionsUtils.isDeletedAction(parentReportAction);

What changes do you think we should make in order to solve the problem?

We need to hide it if the money request is submitted. To know whether it's submitted or not, we can use the same check-in #32796, specifically:

App/src/libs/ReportUtils.ts

Lines 3815 to 3818 in 8e2fb67

	const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat;
	if (isOwnExpenseReport && PolicyUtils.isPaidGroupPolicy(policy)) {
	return isDraftExpenseReport(report);
	}

We only check the submitted status (isDraftExpenseReport true means open, not submitted) in an expense report that is linked with a paid policy.

We need to apply this check in both MoneyRequestHeader and in ReportUtils.canDeleteReportAction.

App/src/libs/ReportUtils.ts

Lines 1139 to 1141 in 8e2fb67

	if (isActionOwner) {
	return true;
	}

if (isActionOwner) {
    if (isExpenseReport(report) && PolicyUtils.isPaidGroupPolicy(policy)) {
        return isDraftExpenseReport(report);
    }
    return true;
}

App/src/components/MoneyRequestHeader.js

Lines 115 to 119 in 8e2fb67

	threeDotsMenuItems.push({
	icon: Expensicons.Trashcan,
	text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
	onSelected: () => setIsDeleteModalVisible(true),
	});

if (ReportUtils.isExpenseReport(moneyRequestReport) && PolicyUtils.isPaidGroupPolicy(policy)) {
    if (ReportUtils.isDraftExpenseReport(moneyRequestReport)) {
        threeDotsMenuItems.push({
            icon: Expensicons.Trashcan,
            text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
            onSelected: () => setIsDeleteModalVisible(true),
        });
    }
} else {
    threeDotsMenuItems.push({
        icon: Expensicons.Trashcan,
        text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
        onSelected: () => setIsDeleteModalVisible(true),
    });
}

[0xmiros]

@sakluger once submitted (but not approved yet), request should not be deletable? I believe so but just to confirm

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

I'm checking on correct expected behavior in Slack: https://expensify.slack.com/archives/C02MW39LT9N/p1706052284329559

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[mallenexpensify]

@s77rt reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

[sakluger]

It's not clear from the reproduction steps, but if Instant Submit is enabled on the workspace, then a submitter should be able to delete an expense on a processing report, but there should be no errors (currently we see the error Unexpected error deleting the money request, please try again later).

[s77rt]

@sakluger I think instant submit is only enabled on free policies. Asked for confirmation here https://expensify.slack.com/archives/C01GTK53T8Q/p1706122924561169

[s77rt]

I'm not able to reproduce this due to billing issues (in olddot). I asked for help here https://expensify.slack.com/archives/C02NK2DQWUX/p1706122093870419. Regardless this is not a blocker. I agree with @bernhardoj. We should hide the delete money request button if the expense report is already submitted (for paid policies only).

🎀 👀 🎀 C+ reviewed
Link to proposal

PS: @bernhardoj There is a util function isPaidGroupPolicyExpenseReport

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@Gonals Please check the two linked slack threads above ^ Thanks!

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Gonals]

I agree with the proposal. I can test with paid policies if needed

[bernhardoj]

Just retested and now I can delete the submitted request.

Screen.Recording.2024-02-01.at.19.24.56.mov

It's weird though seeing the submitted amount as 0. Do we still want to disable the delete button?

@Gonals @s77rt

[s77rt]

@bernhardoj I'm still seeing an error. Maybe you are viewing the optimistic onyx values?

Screen.Recording.2024-02-01.at.11.48.24.PM.mov

[bernhardoj]

@s77rt ah, I think I know why now. If I were an admin of the collect workspace, then I could delete the submitted expense report. But if I were a member/employee, then I can't.

The question is, do we want to disable the delete of submitted expenses for both admin and member?

[s77rt]

In this case we should disable the button only for members. We should match the BE behaviour.

[bernhardoj]

PR is ready

cc: @s77rt

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Don't allow employee to delete submitted request #35744

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: This seems to be a bug since day one, Add DeleteMoneyRequest #19095
• The offending PR has been commented on: Add DeleteMoneyRequest #19095 (comment)
• A discussion in #expensify-bugs has been started: Not needed. More like a onetime bug
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

Requires a paid workspace e.g. collect workspace

1. Login as an employee
2. Create a new money request
3. Submit the expense report
4. Go to the money request and Verify you cannot delete it
5. Login as an admin
6. Go to the money request and Verify you can delete it

[sakluger]

Thanks @s77rt for completing the BZ checklist ahead of time!

Everyone has been paid out. 🙇