[HOLD for payment 2024-01-04] [$500] [Wave 6: Workspace Chats] IOU-The request created is not displayed in the manual expense created page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap employee Workspace chat
3. Tap on a exsisting manual expense which is created and submitted.( if not create a manual expense and submit it)
4. Tap plus icon near compose
5. Tap request money
6. Enter amount
7. Tap next
8. Tap request

Expected Result:

On paid policy, if the expense report is not in open state, do not show the Request Money option in the menu on the expense report. Only in case the expense report is open.

This is only the case for paid policies

Actual Result:

The request created is not displayed in the manual expense created page.Request created is shown only in Worspace chat page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6308623_1702285574223.az_recorder_20231209_015344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ae27c329f45f3a6
• Upwork Job ID: 1734161470412218368
• Last Price Increase: 2023-12-11
• Automatic offers:
• hoangzinh | Reviewer | 28062552
• bernhardoj | Contributor | 28062553

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ae27c329f45f3a6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Creating a new request in a submitted expense report will create the money request action on the chat report instead on the expense report.

What is the root cause of that problem?

Currently, we allow user to request money on a submitted expense report.

App/src/libs/ReportUtils.ts

Lines 3725 to 3728 in 3d56ca3

	* Users can request money:
	* - in policy expense chats only if they are in a role of a member in the chat (in other words, if it's their policy expense chat)
	* - in an open or submitted expense report tied to a policy expense chat the user owns
	* - employee can request money in submitted expense report only if the policy has Instant Submit settings turned on

But after this PR, when we submit an expense report, we now clear the iouReportID so every new request won't be created on the submitted expense report and instead a new expense report is created.

App/src/libs/actions/IOU.js

Lines 2819 to 2830 in 3d56ca3

	...(parentReport.reportID
	? [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${parentReport.reportID}`,
	value: {
	...parentReport,
	hasOutstandingIOU: false,
	hasOutstandingChildRequest: false,
	iouReportID: null,
	},
	},

What changes do you think we should make in order to solve the problem?

Based on the new expected behavior, we want to hide the request money option if the expense report is not open, only for the paid policy.

(add this to canRequestMoney, we need to pass a new param policy from the component that uses this)

if (isMoneyRequestReport(report)) {
    const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat;
    if (isOwnExpenseReport && (policy.type === 'team' || policy.type === 'corporate')) {
        return isDraftExpenseReport(report);
    }

    return (isOwnExpenseReport || isIOUReport(report)) && !isReportApproved(report) && !isSettled(report?.reportID);
}

We will need to update the unit test too.

[yh-0218]

I think this is expected result.

[hoangzinh]

@bernhardoj thanks for your proposal. Can you get confirmation on the PR you mentioned that this is our expectation, not a regression bug? Thanks

we now clear the iouReportID so every new request won't be created on the submitted expense report and instead a new expense report is created.

[bernhardoj]

Based on this comment on the PR, it's expected. But just to be safe, I think we can have @mountiny to have a look at this issue and the solution that I propose.

[hoangzinh]

@mountiny do you mind taking a look at my comment here #32796 (comment)? Thanks

[mountiny]

Ah good point, if this is paid policy, then we create open reports, once submitted new requests should go to a new open report.

So I think the solution would be that on the + icon in the non-open expense report on paid policy, we should hide the Request money option, you cannot request money from there but either from the workspace chat or from the Global create

[hoangzinh]

sorry @mountiny. Can you clarify what does "non-open expense report" mean? And will it apply also for free policy? Thanks

[mountiny]

If the expense report is not a draft report. so the stateNum and statusNum are not 0.

Free policies, cannot have open reports so there we have logic that if the expense report is padi, you cannot request more money there

[hoangzinh]

Thanks @mountiny for clarifying. @bernhardoj can you update your solution with the new expectation in the GH description? Thanks

[bernhardoj]

@hoangzinh updated my proposal

[hoangzinh]

@bernhardoj I don't think your solution is correct. According to @mountiny comment here #32796 (comment), free policy cannot have open reports. In other the words isDraftExpenseReport is always false for expense reports of a free policy

[bernhardoj]

@hoangzinh yes, but we have this condition policy.type !== CONST.POLICY.TYPE.FREE.

Maybe we can switch the position of the condition.

[hoangzinh]

@bernhardoj My point is do we need to check policy.type !== CONST.POLICY.TYPE.FREE?, because if I understand correctly, the function isDraftExpenseReport can cover both paid policy and free policy.

[bernhardoj]

Ah, I see. Do you mean we can just do it like this?

// this will only return true on a paid policy expense report, right?
if (isDraftExpenseReport(report)) {
    return true;
}

[hoangzinh]

Yeah right, and If I understand correctly. We might just replace isExpenseReport with isDraftExpenseReport in this LOC

[bernhardoj]

Hmm, if we replace isExpenseReport with isDraftExpenseReport then we won't be able to request on a free policy expense report.

[mountiny]

function canRequestMoneyOnThisMoneyRequestReport() {
  if (isExpenseReport) {
    if (policyType == free) {
      if (report.state ==1 && report.status ==1 ) {
        return true;
      }
    } else if (policyType == 'team' OR policyType == 'corporate') {
       if (report.state ==0 && report.status ==0 ) {
         return true;
       }
    }
  }
  if (isIOUReport) {
    if (state ==1 && status ==1 ) {
      return true;
     }
   }
   return false;
}

[bernhardoj]

// this will only return true on a paid policy expense report, right?
if (isDraftExpenseReport(report)) {
return true;
}

I just tested and this doesn't work.

This is our current logic for the money request report.

App/src/libs/ReportUtils.ts

Lines 3793 to 3797 in 6785032

	// User can request money in any IOU report, unless paid, but user can only request money in an expense report
	// which is tied to their workspace chat.
	if (isMoneyRequestReport(report)) {
	return ((isExpenseReport(report) && isOwnPolicyExpenseChat) || isIOUReport(report)) && !isReportApproved(report) && !isSettled(report?.reportID);
	}

If I would translate the above pseudo-code, then I think the new code would be:

if (isMoneyRequestReport(report)) {
    const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat;
    if (isOwnExpenseReport && (policy.type === 'team' || policy.type === 'corporate')) {
        return isDraftExpenseReport(report);
    }

    return (isOwnExpenseReport || isIOUReport(report)) && !isReportApproved(report) && !isSettled(report?.reportID);
}

@hoangzinh What do you think?

[hoangzinh]

^ look good from me. What do you think @mountiny? #32796 (comment)

[mountiny]

Looking swell lets go

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @hoangzinh

[hoangzinh]

Thanks @bernhardoj , please don't forget to keep your proposal up-to-date with your comment here #32796 (comment)

[bernhardoj]

@bernhardoj ah you're right, updated.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Disable request money on a paid policy submitted expense #33182

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hoangzinh]

Regression Test Proposal

1. Sign in to an Expensify account that has a paid WS chat
2. Go to that paid WS chat
3. Request money in USD currency
4. Press the request preview to open the IOU report
5. Press the add action (+) button
6. Verify there is a Request money option
7. Submit the request
8. Press the add action (+) button again
9. Verify there is no Request money option

Do we agree 👍 or 👎

[hoangzinh]

Hey, @bernhardoj do you find any regression PR causing this issue? I'm thinking this issue is a bug or an improvement.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @hoangzinh $500, paid via Upwork
• Contributor+: @bernhardoj, $500 paid via Upwork

Upwork job is here: https://www.upwork.com/jobs/~010ae27c329f45f3a6