[WAITING ON CHECKLIST] Android - Request Money - A black area appears in the receipt

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.11.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Tap + > Request money > Manual.
2. Enter amount and select a participant.
3. On the confirmation page, tap 3-dot menu > Add receipt.
4. Add a receipt.
5. Tap Continue and enable the camera while using the app
6. Take a picture

Expected Result:

No black area appears in the receipt

Actual Result:

A black area appears in the receipt

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen_Recording_20231211_111508_New.Expensify.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0111dc7857515d0314
• Upwork Job ID: 1734362601456140288
• Last Price Increase: 2023-12-12
• Automatic offers:
• mkhutornyi | Contributor | 28039255

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[stitesExpensify]

Most likely related to this pr. There are already another android scan issue linked as well, so it is likely the same issue

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0111dc7857515d0314

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[stitesExpensify]

I'm also unable to test this because I don't have a physical android device

[jliexpensify]

Who's got 2 thumbs and a Pixel 3a? This guy.

[jliexpensify]

I'm on version 1.4.11-4. Can repro - the black screen is temporary, it appears for ~5 seconds.

[stitesExpensify]

@jliexpensify can you try scanning this QR code and testing again? #32854 (comment)

[mkhutornyi]

That PR didn't fix this issue. Different root cause

[stitesExpensify]

Good to know! Have you identified the root cause?

[jliexpensify]

@stitesExpensify yeah still an issue

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Request Money - A black area appears in the receipt

What is the root cause of that problem?

This is regression from #28618 so #31519 fix was reverted:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Lines 207 to 214 in 86a2521

	<NavigationAwareCamera
	ref={camera}
	device={device}
	style={[styles.cameraView]}
	zoom={device.neutralZoom}
	photo
	cameraTabIndex={1}
	/>

This is old component:

App/src/pages/iou/ReceiptSelector/index.native.js

Lines 208 to 219 in 86a2521

	<View style={[styles.cameraView]}>
	<View style={styles.flex1}>
	<NavigationAwareCamera
	ref={camera}
	device={device}
	style={[styles.flex1]}
	zoom={device.neutralZoom}
	photo
	cameraTabIndex={pageIndex}
	/>
	</View>
	</View>

What changes do you think we should make in order to solve the problem?

Re-apply wrapping NavigationAwareCamera with View so exactly copy from old component

[luacmartins]

Tested in staging. This is a pass.

[jliexpensify]

Payment Summary:

• Contributor: @mkhutornyi $500
• C+ @parasharrajat $500 (request on New.Dot)

Upworks job here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix receipt scan issues on mobile #32886

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Bump @parasharrajat to complete checklist.

Paid and job closed!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1433613058https://github.com/Expensify/App/pull/28618
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Login any account
2. Go to 1:1 DM > Composer + > Request money
3. Enter amount and proceed to confirmation page
4. Tap 3-dot menu > Add receipt
5. Upload a receipt from gallery
6. Verify that app doesn't crash and receipt preview shows correctly
7. Tap 3-dot menu > Add receipt
8. Capture photo from camera
9. Verify that app doesn't crash and receipt preview shows correctly

Do you agree 👍 or 👎 ?

[luacmartins]

We already have steps covering this flow and QA caught this issue. So I think we're good without new steps.

[melvin-bot]

@parasharrajat @jliexpensify @stitesExpensify @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@parasharrajat, @jliexpensify, @stitesExpensify, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[jliexpensify]

Thanks Rajat, test added!

[parasharrajat]

Payment requested as per #32844 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat based on this summary.