[HOLD for payment 2023-12-20] Android - IOU - Unable to capture receipt photo, the camera error displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #28618

Action Performed:

Precondition: user should be Signed In

1. Open app
2. Tap on FAB
3. Select Scan tab
4. Tap on Continue button and grant the camera permission
5. Tap on shot camera button

Expected Result:

Receipt photo should be captured and user should be navigated on the attendee screen

Actual Result:

Camera error displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309313_1702313741861.screen-20231211-185142.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Unable to capture receipt photo, the camera error displayed

What is the root cause of that problem?

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 210 in eebd7ee

cameraTabIndex={pageIndex}

Here, passing wrong cameraTabIndex as pageIndex is no longer used and undefined

What changes do you think we should make in order to solve the problem?

pass cameraTabIndex={1} similar to web:

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 212 in eebd7ee

cameraTabIndex={1}

[francoisl]

@mkhutornyi do you know what PR caused this regression? Looks like this part of the code didn't change recently.

[mkhutornyi]

The offending PR is huge and these kinds of minor regressions were expected
https://expensify.slack.com/archives/C01GTK53T8Q/p1702303752079129

[francoisl]

Ah ok got it, thanks. Still trying to confirm your solution but I'm getting an (unrelated) error trying to build android at the moment, looking into it.

[ishpaul777]

@mkhutornyi solution works here is demo 👇

VIDEO-2023-12-11-23-50-19.mp4

not sure if the rounded border styles and padding from the edge is removed intentionally or by mistake

[mkhutornyi]

@francoisl this also happens on iOS as well. If you have iPhone, you can also test with it

[francoisl]

Ah ok great. Let's go with your solution then @mkhutornyi!

[mkhutornyi]

PR is ready

[mkhutornyi]

@francoisl the fix also applies to iOS but unfortunately not able to test because it requires real device (iOS simulator doesn't have camera feature). Btw android works well

[situchan]

I can help with iOS testing. Confirmed fix on my iPhone

ios.MP4

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[francoisl]

Assigning a CME to handle payment to @mkhutornyi.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix unable to scan receipt, the camera error display #32854

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment (Needs manual offer from BZ)

[puneetlath]

@mkhutornyi can you send me your Upwork profile and I'll send you an offer?

[mkhutornyi]

sure - https://www.upwork.com/freelancers/~010baa511a9de4eeec

[puneetlath]

Offer sent. Will play on Dec 20.

https://www.upwork.com/nx/wm/offer/28060876

[puneetlath]

Paid. Thanks everyone!