[HOLD for payment 2023-09-27] [$1000] After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in with any of your logins
3. Create a new workspace or open an existing one
4. Open the workspace & click on "Members"
5. Click on 'Invite' button
6. Search for an invalid phone number (+2523234211)
7. Select the user > click on "Next" > click on "Invite"
8. Select the user & click on the "Remove" button
9. Click on 'Invite' button

Expected Result:

The previously added contact should appear as a phone number, without the @expensify.sms termination

Actual Result:

A previously added contact is displayed as a phone number with @expensify.sms at the end

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.58-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6180252_Recording__119.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b0b1a782b2526c6
• Upwork Job ID: 1696345977519468544
• Last Price Increase: 2023-08-29
• Automatic offers:
• mollfpr | Reviewer | 26454047
• pradeepmdk | Contributor | 26454050

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a phone contact from WS, it starts showing up in contacts as @expensify.sms in the invite page.

What is the root cause of that problem?

We are not formatting the @expensify.sms text anywhere for invite page.

What changes do you think we should make in order to solve the problem?

We can remove the sms domain in CheckboxListItem with formatPhoneNumber of LocalePhoneNumber by importing like this

import * as LocalePhoneNumber from '../../libs/LocalePhoneNumber';

and update this

{LocalePhoneNumber.formatPhoneNumber(item.text)}

at

App/src/components/SelectionList/CheckboxListItem.js

Line 69 in d42967a

{item.text}

We can wrap the alternate text as well with this similar to the getParticipantsOptions of the OptionLisUtils
if we want to avoid it in cases for alternate text as well just to be safe but presently alternateText has no @expensify.sms portion to be removed.

App/src/components/SelectionList/CheckboxListItem.js

Line 76 in d42967a

{item.alternateText}

{LocalePhoneNumber.formatPhoneNumber(item.alternateText)}

What alternative solutions did you explore? (Optional)

Solution 1
We can instead format the text directly in the OptionListUtils function formatMemberForList here

App/src/libs/OptionsListUtils.js

Line 1047 in a5ab459

text: lodashGet(member, 'text', '') || lodashGet(member, 'displayName', ''),

with LocalePhoneNumber.formatPhoneNumber
and do it similarly for alternateText, name in Avatar if necessary.
This formatMemberForList function is used only for invite page and presently we are not showing any tooltip for CheckboxItem so this solution and the primary solution has no difference. But if we like to show tooltip later, then we need to remove .sms from the name of the tooltip as well. If and when tooltip is implemented, the text there need to be formatted again if we implement the first solution.
This solution is also preferable because the function is meant to format and the phone number formatting logic also is better to be implemented in this.

Solution 2 (too big a refactor for this bug)
Use the getParticipantOptions (because this function has already proper phone number formatting logic) of OptionListUtils to get participant details in workspace members and invite pages instead of individually formatting in the page itself (as done in members page) or each with formatMemberForList (in contacts page) and use the regular logic of using icons object with MultipleAvatars component to show Avatar and tooltips as earlier in CheckboxListItem.

[jliexpensify]

Confirmed that we shouldn't show @expensify.sms anywhere

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b0b1a782b2526c6

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms

What is the root cause of that problem?

Root cause is when we invite displayName stored in with domainName@expensify.sms in optimisticData
when we invite

App/src/libs/actions/Policy.js

Line 331 in a5ab459

const logins = _.map(_.keys(invitedEmailsToAccountIDs), (memberLogin) => OptionsListUtils.addSMSDomainIfPhoneNumber(memberLogin));

we are creating OptionsListUtils.addSMSDomainIfPhoneNumber for storing the optimisticData

App/src/libs/PersonalDetailsUtils.js

Line 118 in fd755ee

displayName: login,

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/Policy.js

Line 331 in a5ab459

const logins = _.map(_.keys(invitedEmailsToAccountIDs), (memberLogin) => OptionsListUtils.addSMSDomainIfPhoneNumber(memberLogin));

we need remove OptionsListUtils.addSMSDomainIfPhoneNumber here and add it into

App/src/libs/PersonalDetailsUtils.js

Line 115 in fd755ee

login,

and

App/src/libs/actions/Policy.js

Line 398 in a5ab459

employees: JSON.stringify(_.map(logins, (login) => ({email: login}))),

so only we have this addSMSDomainIfPhoneNumber for login not for the displayName

or just formatting the
displayName: LocalePhoneNumber.formatPhoneNumber(login),

App/src/libs/PersonalDetailsUtils.js

Line 118 in fd755ee

displayName: login,

Addional fix Needed same issue for other places

we need fix some other place too

1. RequestMoney api optimisticData data
   

   App/src/libs/actions/IOU.js

   Line 447 in fd755ee

   displayName: participant.displayName || payerEmail,

   
   here participant.login is without domain so we need switch payerEmail to login
2. split api above solution needed here
   

   App/src/libs/actions/IOU.js

   Line 837 in fd755ee

   displayName: participant.displayName || email,

[mollfpr]

Thanks for the proposals!

@c3024 @pradeepmdk Why does it only happen on the failing phone number deleted? The other phone number that is valid also has the domain in their displayName and login, but it displays just fine.

[pradeepmdk]

@mollfpr because when api falling onyxData empty but we stored in the optimisticData with OptionsListUtils.addSMSDomainIfPhoneNumber so that its happening. so that in my proposal remove the addSMSDomainIfPhoneNumber on display name

App/src/libs/actions/Policy.js

Line 346 in a5ab459

...newPersonalDetailsOnyxData.optimisticData,

[c3024]

@mollfpr Is there a duplicate for the number 0878-... in the personal details or in the invite options in your screen?

[mollfpr]

@pradeepmdk Sorry, I don't understand your point. In the above image, the valid phone number also has the domain, but it displays fine; why is that?

@c3024 Nope, it just added.

[c3024]

If display name has expensify.sms then I think it should show expensify.sms because we are not stripping it anywhere. Just for clarification, there are no two options or personal details one with +62878732837@expensify.sms and another with 0 878-732-837 on your screen, right? @mollfpr

[mollfpr]

@c3024 Thanks, I understand now the issue is. Your alternative solution 1, looks good. We format the text and alternate text on the WorkspaceMembersPage, so I think we need to do the same for the invite page.

I think we don't have anything wrong with the API action and the optimistic data, so I prefer to keep it that way.

Let's go with @c3024 alternative solution 1 in their proposal. For note, I think we just need to format the text and alternateText, no need for the avatar.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pradeepmdk]

@mollfpr This issue was when we storing optimisticData in Onyx whenever API falling.

App/src/libs/actions/Policy.js

Line 331 in a5ab459

const logins = _.map(_.keys(invitedEmailsToAccountIDs), (memberLogin) => OptionsListUtils.addSMSDomainIfPhoneNumber(memberLogin));

App/src/libs/actions/Policy.js

Line 346 in a5ab459

...newPersonalDetailsOnyxData.optimisticData,

we need to fix the root case for avoiding the displayName store as @expensify.sms

OptionsListUtils.js
this will not solve all the places it will work only this place.

If you want check this exactly when api failed case phone number when we go to create task assignee means same like this format only it will displayed, same for moneyrequest, split bill as well

[pradeepmdk]

@mollfpr @Li357

I think we don't have anything wrong with the API action and the optimistic data, so I prefer to keep it that way.

this is wrong right? the display name with @expensify.sms.This happened only from optimisticData but API give correct response without @expensify.sms

If the AddMembersToWorkspace api is sucess means personalDetailsList displayname come with without @expensify.sms:

if we fix the displayname. all the place working correctly.

[Li357]

@pradeepmdk Seems like you're right. I would prefer to fix the optimistic data generated, can you demonstrate this fix working everywhere we currently show @expensify.sms?

[mollfpr]

@pradeepmdk You have a good point on the optimistic data, but fixing the optimistic data is not enough. We also need to format the option list too. Otherwise, the issue still persists for the wrong existing data.

I also suspect that this issue is a regression from #22904.

[c3024]

How about not showing the personal details with errors at all in the invite page?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 26121-remove-domain-name #26638

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @mollfpr requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pradeepmdk]

@mollfpr Pr is ready

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @pradeepmdk got assigned: 2023-09-01 15:49:35 Z
• when the PR got merged: 2023-09-14 16:55:48 UTC
• days elapsed: 9

On to the next one 🚀

[jliexpensify]

Bump @mollfpr to complete the checklist!

[mollfpr]

@jliexpensify The second PR is still on QA, so the payment date will be change.

[jliexpensify]

@mollfpr is this the other PR? #26638

[mollfpr]

@jliexpensify It's #27408

[jliexpensify]

Cool, just changed the payment date and will check back next week to see how things are going - thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 26121-remove-domain-name  #27408

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @mollfpr requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary:

• Contributor: @pradeepmdk $1000
• C+: @mollfpr $1000

Upworks Job

@mollfpr bump to complete the checklist, thanks!

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I couldn't find the offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

For WorkSpace

1. Open https://staging.new.expensify.com/
2. Open the workspace or create one & click on "Members"
3. Click on the 'Invite' button
4. Search for an invalid phone number (+2523234211)
5. Select the user > click on "Next" > click on "Invite"
6. Select the user & click on the "Remove" button
7. Click on the 'Invite' button
8. Verify the display name on the newly added user without the domain name

For Request Money

1. Open the Request money from the fab menu
2. go to offline
3. Create a Request money with an invalid phone number (either manual or distance)
4. Verify the display name on the chat page without the domain name

For Split bill

1. Open the Split bill from the fab menu
2. go to offline
3. Create split money with an invalid phone number
4. Verify the display name on the chat page without the domain name

[jliexpensify]

Paid and job closed!