[HOLD for payment 2023-08-28] [$1000] splitting bill with phone account shows @expensify.sms

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. login with an sms account
2. split bill with a few members
3. Check the who paid field's subtitle text

Expected Result: @expensify.sms should not be shown

Actual Result:

@expensify.sms should is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-07-14.14-53-13-346.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688810314872429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128597348b75205c2
• Upwork Job ID: 1682899214742786048
• Last Price Increase: 2023-08-05
• Automatic offers:
• chiragxarora | Contributor | 26071204
• chiragxarora | Reporter | 26071208
• situchan | Contributor | 26071280

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

PROPOSAL

Please re-state the problem that we are trying to solve in this issue.

splitting bill with phone account shows @expensify.sms

What is the root cause of that problem?

Root cause of the issue is that in split bill flow, when we are fetching the payee's personal details by the method getIOUConfirmationOptionsFromPayeePersonalDetail, we have not formatted the text and alternate text which we end up showing in <MoneyRequestConfirmationList/> > <OptionsSelector/>

App/src/libs/OptionsListUtils.js

Lines 878 to 894 in 60f4817

	function getIOUConfirmationOptionsFromPayeePersonalDetail(personalDetail, amountText) {
	return {
	text: personalDetail.displayName ? personalDetail.displayName : personalDetail.login,
	alternateText: personalDetail.login || personalDetail.displayName,
	icons: [
	{
	source: UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID),
	name: personalDetail.login,
	type: CONST.ICON_TYPE_AVATAR,
	id: personalDetail.accountID,
	},
	],
	descriptiveText: amountText,
	login: personalDetail.login,
	accountID: personalDetail.accountID,
	};
	}

What changes do you think we should make in order to solve the problem?

We need to format the alternate text and display name fields using formatPhoneNumber() method in LocalePhoneNumber util

What alternative solutions did you explore? (Optional)

We can find other inconsistencies (if any) and fix them all at once

[MitchExpensify]

Commented in Slack

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Confirmed @expensify.sms is not expected to be shown anywhere in app

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128597348b75205c2

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[KrAbhas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If the payee is logged in using phone number, then @expensify.sms should not be displayed while splitting bill after login id.

What is the root cause of that problem?

The login information is displayed plainly from props without formatting and as it has the format <phone number>@expensify.sms

What changes do you think we should make in order to solve the problem?

In the function getIOUConfirmationOptionsFromPayeePersonalDetail we need to provide check for if there is phone number(sms) based login, then we need to format that phone number by removing @expensify.sms in another variable and then put it in alternateText.
Since we may want to have a different format in which the login detail is displayed and not like the displayName, we will write a formatter for this purpose and the end result will be something like the one attached in the image.

App/src/libs/OptionsListUtils.js

Lines 905 to 921 in cd851d0

	function getIOUConfirmationOptionsFromPayeePersonalDetail(personalDetail, amountText) {
	return {
	text: personalDetail.displayName ? personalDetail.displayName : personalDetail.login,
	alternateText: personalDetail.login || personalDetail.displayName,
	icons: [
	{
	source: UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID),
	name: personalDetail.login,
	type: CONST.ICON_TYPE_AVATAR,
	id: personalDetail.accountID,
	},
	],
	descriptiveText: amountText,
	login: personalDetail.login,
	accountID: personalDetail.accountID,
	};
	}

Finally :

Details

What alternative solutions did you explore? (Optional)

NA

[MitchExpensify]

One note to the internal engineer eventually assigned - Lets double check if we're actively removing @expensify.sms from the front end or the back end across the board just to be 100% sure

[MitchExpensify]

Friendly reminder to review the existing proposals @0xmiroslav 👍

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[chiragxarora]

@0xmiroslav pls review the proposals 😅

[melvin-bot]

@MitchExpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[0xmiros]

reviewing now

[chiragxarora]

Bump: @0xmiroslav

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[chiragxarora]

PR #24441 is ready for review @situchan

[melvin-bot]

🎯 ⚡️ Woah @situchan / @chiragxarora, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @chiragxarora got assigned: 2023-08-11 15:38:04 Z
• when the PR got merged: 2023-08-15 15:13:59 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• formatting phone login #24441

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @chiragxarora requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)
• @chiragxarora requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Bump on the BZ steps @situchan

[MitchExpensify]

Payment summary:

Reporting: @chiragxarora $250 (Upwork)
C: @chiragxarora $1500 (Upwork)
C+: @situchan $1500 (Upwork)

[MitchExpensify]

Paid!

[melvin-bot]

@MitchExpensify, @stitesExpensify, @chiragxarora, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

Regarding BZ checklist:
This is minor inconsistent display issue specific to phone users and does not affect any app logic including split bill.
No need regression test.

[MitchExpensify]

Great, thanks for confirming @situchan - All done here!