feat(): adds entity discussion settings

[tannerjt]

1. Description:

• Adds Discussion pane to group and content workspaces to set typeKeywords
• Adds Discussion pane to site workspace to set capability
• Moves discussion settings on Discussion Board workspace to settings pane

Site Discussion Settings to enable / disable capability

Discussion Board settings

Content discussion settings

Group discussion settings

1. Instructions for testing:

2. Closes Issues: # (if appropriate)

3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

4. used semantic commit messages

5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (aba8f7b) 100.00% compared to head (2c9d629) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       753    +4     
  Lines        13565     13591   +26     
  Branches      2351      2352    +1     
=========================================
+ Hits         13565     13591   +26     

Files	Coverage Δ
...mmon/src/content/_internal/ContentBusinessRules.ts	100.00% <ø> (ø)
...ages/common/src/content/_internal/ContentSchema.ts	100.00% <ø> (ø)
...rc/content/_internal/ContentUiSchemaDiscussions.ts	100.00% <100.00%> (ø)
...kages/common/src/content/_internal/computeProps.ts	100.00% <100.00%> (ø)
packages/common/src/content/edit.ts	100.00% <100.00%> (ø)
...rc/core/schemas/internal/getEntityEditorSchemas.ts	100.00% <100.00%> (ø)
...mmon/src/discussions/_internal/DiscussionSchema.ts	100.00% <ø> (ø)
...rc/discussions/_internal/DiscussionUiSchemaEdit.ts	100.00% <ø> (ø)
...iscussions/_internal/DiscussionUiSchemaSettings.ts	100.00% <100.00%> (ø)
packages/common/src/discussions/utils.ts	100.00% <100.00%> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[juliannemarik]

This all looks good to me - nice work!

[rweber-esri]

LGTM, nj!

[rweber-esri]

Minor, we could eliminate the optional chaining operators and the || [] in the return expression by refactoring slightly to:

export function setDiscussableKeyword(
  typeKeywords: string[],
  discussable: boolean
): string[] {
  const updatedTypeKeywords = (typeKeywords || []).filter(
    (typeKeyword: string) => typeKeyword !== CANNOT_DISCUSS
  );
  if (!discussable) {
    updatedTypeKeywords.push(CANNOT_DISCUSS);
  }
  return updatedTypeKeywords;
}

[github-actions]

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.