fix(hub-discussions): user can read channel if group is non-discussable

[brittneyjb]

1. Description: Updated canSomeUserGroupto allow a user in a non-discussable group to read a channel with the canReadChannel function.

2. Instructions for testing: run npm run test to run unit updated unit tests

3. Closes Issues: #7454

4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

5. used semantic commit messages

6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a90b6d) 100.00% compared to head (8b8f020) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          737       737           
  Lines        13162     13177   +15     
  Branches      2245      2252    +7     
=========================================
+ Hits         13162     13177   +15     

Files Changed	Coverage Δ
...ckages/discussions/src/utils/channel-permission.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rweber-esri]

I pulled this branch down, yalc'd it into my local API env & verified users that can access posts from GET /v1/posts (search) can now also access the posts from GET /v1/posts/:postId (get-by-id), and similarly, users that can access channels from GET /v1/channels (search) can now also access channels from GET /v1/channels/:channelId (get-by-id) when one, or more, of the channel groups contains the cannotDiscuss typekeyword. I also verified that users that cannot access the same channels/posts in the search endpoints also cannot do a get-by-id for those channels/posts. Nice work!

[rweber-esri]

Super minor, but the nested if on line 140 doesn't add a lot of value. I believe this could be simplified to just:

      if (action === ChannelAction.READ_POSTS) {
        if (!group) {
          return false;
        }
      } else if (!group || !isGroupDiscussable(group)) {
        return false;
      }