[Hotfix] Ensure CMS Design System npm package version is 2.5.0 #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilR8
changed the title
|
✨ See the Django Site in action ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EREGCSC-2779 (Vitest fixes) introduced a regression where the CMS Design System npm package was updated to a newer minor version. Our targeted version is
2.5.0, but the pull request for 2779 rebuilt thepackage-lock.jsonfile to install2.13.0.We don't want
2.13.0because it includes unwanted style changes. Specifically, elementfocusstyles are pink instead of blue.We've previously attempted to upgrade to
2.13.0based on a Snyk suggestion, but that upgrade was reverted back to2.5.0for this same reason.Except we didn't actually lock the version to
2.5.0. Note this line frompackage.json:The caret (
^) before the version indicates that minor (0.X) and patch (0.0.X) versions can be updated if available and compatible. See NPM documentation here. This means that when rebuilding thepackage-lockfile, the most recent2.X.Xversion will be installed. In our case,2.13.0is the most recent version and was installed.This issue is happening now because the
package-lock.jsonfile was recently rebuilt as part of EREGCSC-2779.This pull request changes:
Steps to manually verify this change:
tabto navigate around the site via the keyboard. Ensure that you don't see any pink focus styles around any elements.