Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Revert CMS Design System back to v2.5 #1044

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

PhilR8
Copy link
Contributor

@PhilR8 PhilR8 commented Nov 8, 2023

Resolves regression introduced with updated version of CMS Design System

Description
Snyk created a Pull Request that bumped CMS Design System's NPM package from v2.5.0 to 2.13.0. This was merged into main before it was discovered that it introduced a regression where the focus styles (outline and background) were changed and did not always look good.

This pull request changes:

  • Reverts CMS Design System package version to 2.5.0

Steps to manually verify this change:

  1. Tab around the homepage and make sure the focus styles aren't pink outlines and sometimes white backgrounds

Copy link

github-actions bot commented Nov 8, 2023

✨ See the Django Site in action

@PhilR8 PhilR8 added the Merge when approved This PR can be merged by anyone once it is approved label Nov 8, 2023
Copy link
Contributor

@peggles2 peggles2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peggles2 peggles2 merged commit 709dc2c into main Nov 9, 2023
19 checks passed
@PhilR8 PhilR8 removed the Merge when approved This PR can be merged by anyone once it is approved label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants