Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DELETEing with if-unused/if-empty query parameters #334

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Support DELETEing with if-unused/if-empty query parameters #334

merged 5 commits into from
Jun 17, 2024

Conversation

inikulshin
Copy link
Contributor

No description provided.

@inikulshin inikulshin changed the title Support DELETEing with if-unused/if-empty query Support DELETEing with if-unused/if-empty query parameters May 29, 2024
@inikulshin
Copy link
Contributor Author

inikulshin commented May 30, 2024 •
edited
Loading

@Pliner can you review it, please?

#333 (UnexpectedHttpStatusCodeException: more verbose message) was a prerequisite to this one.
Tests should know response content (reason of BadRequest) to assert it caused by query parameters.

zidad
zidad previously approved these changes Jun 10, 2024
View reviewed changes
Source/EasyNetQ.Management.Client/DeleteExchangeCriteria.cs Outdated Show resolved Hide resolved
Source/EasyNetQ.Management.Client/DeleteQueueCriteria.cs Outdated Show resolved Hide resolved
Pliner
Pliner previously approved these changes Jun 10, 2024
View reviewed changes
@inikulshin inikulshin dismissed stale reviews from Pliner and zidad via 6858fcb June 16, 2024 08:15
@zidad
Copy link
Member

zidad commented Jun 17, 2024

@inikulshin is this OK to merge as far as you are concerned?

@inikulshin inikulshin merged commit ffe1522 into master Jun 17, 2024
9 checks passed
@inikulshin inikulshin deleted the delete-query branch June 17, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zidad zidad zidad approved these changes

@Pliner Pliner Pliner left review comments

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inikulshin @zidad @Pliner