UnexpectedHttpStatusCodeException: more verbose message #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulshin
requested review from
Pliner,
zidad,
micdenny and
luigiberrettini
as code owners
Pliner
reviewed
May 28, 2024
Source/EasyNetQ.Management.Client/UnexpectedHttpStatusCodeException.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 28, 2024 13:46
Pliner
reviewed
May 28, 2024
| StatusCode = statusCode; | ||
| } | ||
|
|
||
| public static async Task<UnexpectedHttpStatusCodeException> FromHttpResponseMessageAsync(HttpResponseMessage response) |
There was a problem hiding this comment.
You also might consider adding cancellation token here...
There was a problem hiding this comment.
@Pliner well, ok.
However, HttpContent.ReadAsStringAsync(CancellationToken) exists since .NET 5.0 only.
Pliner
previously approved these changes
May 28, 2024
|
@Pliner I added CancellationToken, please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add response.Content (as string) to exception message.