Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge b4bdev 20240420 #2482

Merged
merged 76 commits into from
Apr 22, 2024
Merged

Merge b4bdev 20240420 #2482

merged 76 commits into from
Apr 22, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Apr 20, 2024

Description of changes

merge in master ctsm5.2.0 to b4b-dev

Fixes: #2470
Fixes: #2471
Fixes: #2474
Fixes: #2414
Fixes: #2437
Fixes #2435

olyson and others added 30 commits September 13, 2023 09:48
Remove a case of negative snocan in CanopyFluxesMod to resolve ESCOMP#2366

One-line change that now includes "max(0._r8," to prevent negative
snocan in that part of the code.
QFLX_SOLIDEVAP_FROM_TOP_LAYER
updating input data file paths
slevis-lmwg and others added 21 commits April 15, 2024 16:27
Merging b4b-neon instead of b4b-dev because I expect to push b4b-neon to
b4b-dev soon
B4b neon

Description
Fixes neon bugs related to calendar issue with transient cases created by run_neon and an odd error that can be fixed by removing redundant information in usermod_dirs.

CTSM Issues Fixed:
Fixes ESCOMP#2470
Fixes ESCOMP#2471
Fixes ESCOMP#2474

Are answers expected to change (and if so in what way)?
No, removes bug in NEON cases

Any User Interface Changes (namelist or namelist defaults changes)?
only changes to usermod_dirs

Testing:
OK: ./run_ctsm_py_tests -u
OK: ./run_ctsm_py_tests -s
PASS: ./run_sys_tests -s clm_pymods -c ctsm5.1.dev176 --skip-generate
adding lai_dtlimit to namelist & updating usermods for PLUMBER
experiment bug fix

Address ESCOMP#2433 with changes to the arguments in run_case
fix units for vector hh output

Trivial changes; tested with the clm_short test-suite
One-line fix for izumi NEON-MOAB test error introduced in ESCOMP#2472
PLUMBER2 plumbing (csv file, wrapper script, usermods, and scripts).
New surface datasets and new mksurfdata_esmf tool to create them

Changes to CTSM:
================

All new surface datasets. Transient urban and lake by default turned on
for transient cases.
Ocean is run as baresoil rather than wetland (for clm6_0). The urban
streams file was also
updated. The new surface datasets have new updated input datasets (see
below).

Update the README files.

New surface datasets:
=====================

The new surface datasets are incompatible with previous versions (for
example the ctsm5.1 series)
ctsm5.2.0 and following versions also can NOT use the previous ctsm5.1
datasets.

See the section below about the new datasets used in their creation.
Improvements in how landunits
on coastal areas was also done.

The following fields were added and removed to the list of fields on the
datasets.

Fields added:
   ORGC, BULK, CFRAG, PHAQ (soil data) (currently NOT used by CTSM)
   mapunits (map units from the soil dataset)
   LANDFRAC_MKSURFDATA (for reference NOT used by CTSM)
   PCT_OCEAN (previously PCT_WETLAND was used)

Fields removed:
   AREA, PFTDATA_MASK

New mksurfdata_esmf Tool:
=========================

Implement a parallel version of mksurfdata (mksurfdata_esmf) that uses
ESMF regridding directly
in mksurfdata so that offline mapping files don't have to be created as
a separate step. This
allows mksurfdata to create surface datasets at much higher resolutions

The build for the tool is based on the CESM/CIME build system and uses
cmake. This allows the build
to be kept up with changes in CESM. Currently it's only setup and
working on Derecho. But, this design
will enable it to be built and run on any CESM supported machine (or a
machine that a user ports to).

Any input grid from ccs_config can be used, or the user can supply their
own mesh file to define
the output grid. The user no longer has to add to the list of valid
resolutions as in mksurfdata_map.

Creation of supported single point datasets. These datasets are created
through the use of subset_data.

Test datasets for dynUrban, dynLake, and dynPFT is done with a simple
NCO script.

All datasets can be easily made by running "make all" in the
tools/mksurfdata_esmf directory.

For instructions see:
    tools/mksurfdata_esmf/README.md

New input datasets to mksurfdata_esmf:
======================================

New soil dataset: ISRIC/WISE dataset Batjes (2016)
https://doi.org/10.1016/j.geoderma.2016.01.034
New PFT, soil-color, LAI dataset: Created by Lawrence P.J. 2022
New Glacier datasets: Glacier outlines from RGI version 6 (Arendt et
al., 2017).
   vector data for GrIS and AIS retrieved from BedMachine version 4 and
version 2 (Morlighem et al., 2017, 2020), respectively.
   30-arcsec topography/land mask retrieved GMTED2010 (Danielson and
Gesch, 2011).
New urban datasets:  Gao and O'Neill (2021) and Gao and Pesaresi (2022),
Oleson and Feddema (2020)
New lake datasets: HydroLake: Messager et. al. (2016)

 Conflicts:
	cime_config/usermods_dirs/NEON/defaults/user_nl_clm
@ekluzek ekluzek self-assigned this Apr 20, 2024
@ekluzek ekluzek merged commit 4eb5320 into ESCOMP:master Apr 22, 2024
2 checks passed
@ekluzek ekluzek deleted the merge-b4bdev-20240420 branch April 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
7 participants