Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lake depth raw dataset uses the wrong mask #8

Closed
billsacks opened this issue Dec 16, 2017 · 2 comments
Closed

lake depth raw dataset uses the wrong mask #8

billsacks opened this issue Dec 16, 2017 · 2 comments
Labels
blocked: dependency Wait to work on this until dependency is resolved bug something is working incorrectly science Enhancement to or bug impacting science

Comments

@billsacks
Copy link
Member

Bill Sacks < sacks@ucar.edu > - 2013-03-14 15:22:31 -0600
Bugzilla Id: 1642
Bugzilla CC: rfisher@ucar.edu, subin@berkeley.edu,

Currently, we have a single 3x3min rawdata file that contains both percent lake and lake depth. This file has two masks: one that is a standard landmask, and one that gives a mask of where we have real lake depth data ("LAKEDATAMASK"). Currently, we are using the same mapping files for both of these fields, which (I assume) use the LANDMASK for a mask. This is a problem because it means that the fill value (10m) currently gets averaged with the real data when doing the regridding.

I believe that the right thing to do would be to create a new set of mapping files that uses LAKEDATAMASK as a mask. Once we do that, we might want to split the raw data file into two separate files, so we maintain the notion of a single mask per raw data file. However, apparently Zack Subin has said that this rigorous handling of the mask isn't totally necessary at this point.

Incidentally: I consider this to be a good example of what a file's mask variable should provide: a mask telling you where there are valid data.
@billsacks billsacks added this to the future milestone Dec 16, 2017
This was referenced Dec 16, 2017
Closed
Closed
Closed
Closed
billsacks added a commit that referenced this issue Dec 28, 2017
@billsacks
Merge pull request #8 from NCAR/modularize_infiltration_p3
72070e7 
Finish Infiltration modularization - mainly h2osfc updates

Finish the modularization of subroutine Infiltration. The main focus
here is modularizing the calculation of fluxes out of h2osfc and the
updates of the h2osfc state variable. Flux calculations and state
updates are now done separately. Where a flux calculation depends on a
partially-updated version of h2osfc, this is now made explicit in a way
that could facilitate removing this partial update later.
@billsacks billsacks removed this from the future milestone Nov 5, 2018
@billsacks billsacks added tag: bug - impacts science bug something is working incorrectly and removed type: bug - impacts science labels May 24, 2019
@billsacks billsacks mentioned this issue Jun 12, 2019
Closed
@billsacks
Copy link
Member Author

billsacks commented Jun 12, 2019 •
edited
Loading

Blocked by #286 - Let's wait to tackle this until #286 is resolved.

@billsacks billsacks added the blocked: dependency Wait to work on this until dependency is resolved label Jun 12, 2019
mariuslam pushed a commit to NordicESMhub/ctsm that referenced this issue Aug 26, 2019
@xuyi02
Merge pull request ESCOMP#8 from rgknox/yi-logging-v3
1b02c65 
Yi logging v3
mariuslam pushed a commit to NordicESMhub/ctsm that referenced this issue Aug 26, 2019
@ekluzek
Merge pull request ESCOMP#8 from ekluzek/master
6baebdc 
Bring in NGEET update to sci.1.5.0_api.3.0.0
billsacks pushed a commit to billsacks/ctsm that referenced this issue Nov 12, 2019
@pengbinpeluo
Merge pull request ESCOMP#8 from billsacks/agsys
66bfe8f 
Merge crop-specific and cultivar-specific params into a single structure
@ekluzek ekluzek mentioned this issue Mar 12, 2020
Closed
@olyson olyson mentioned this issue Aug 1, 2021
Closed
MiCurry pushed a commit to MiCurry/CTSM that referenced this issue Sep 16, 2021
@dabail10
Merge pull request ESCOMP#8 from ESCOMP/master
5172f8c 
Fix history variables.
MiCurry pushed a commit to MiCurry/CTSM that referenced this issue Sep 16, 2021
@dabail10
Merge pull request ESCOMP#9 from ESCOMP/cice5_cesm2_0_rel
27d638d 
Merge pull request ESCOMP#8 from ESCOMP/master
@billsacks
Copy link
Member Author

This is probably resolved with the new lake dataset.

slevis-lmwg pushed a commit that referenced this issue Apr 19, 2024
@wwieder
Merge pull request #8 from wwieder/PLUMBERcsv
4a19a1c 
adding lai_dtlimit to namelist & updating usermods for PLUMBER
jedwards4b added a commit to jedwards4b/ctsm that referenced this issue Jun 2, 2024
@jedwards4b
Merge pull request ESCOMP#8 from jedwards4b/fix/status_and_log
2025459 
cleaner format for status output, fix for special handling of ssh sub…
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Merge pull request ESCOMP#8 from NCAR/modularize_infiltration_p3
474dea3 
Finish Infiltration modularization - mainly h2osfc updates

Finish the modularization of subroutine Infiltration. The main focus
here is modularizing the calculation of fluxes out of h2osfc and the
updates of the h2osfc state variable. Flux calculations and state
updates are now done separately. Where a flux calculation depends on a
partially-updated version of h2osfc, this is now made explicit in a way
that could facilitate removing this partial update later.
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@kvrigor
CMake refactoring (ESCOMP#8)
4843785 
Commit summary:

* 7ddcaf9 README updates and other minor changes
* ff3ba44 Made PIO_BUILD_TIMING option functional. Also cleaned PIO CMakeLists.txt
* 5ecdcd3 Rewritten FindPnetcdf.cmake
* 8ead123 Rewritten FindNetCDF.cmake
* eb3af96 Moved clm5 unit test codes under tests/ folder
* a6a3ee8 Added build instructions to README (work-in-progress)
* 6760f31 Made MPI required and set default compiler toolchain according to the detected CMAKE_Fortran_COMPILER_ID.
* 045d8a1 Added CMake option BUILD_MCT.
* 48e46a6 Removed old CMakeLists scripts from CLM5 to avoid confusing it with the standard CMake build process
* d2a8fdc Set default CMAKE_MODULE_PATH and GENF90 path
* 606a907 Replaced 'build_tools' folder with 'cmake'
AGonzalezNicolas added a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@AGonzalezNicolas
Merge commit CMake refactoring (ESCOMP#8) '48437852ecf61d83e4799b1e5a…
fcd2eb8 
…2819228ed2ea54' into eclm
glemieux pushed a commit to glemieux/ctsm that referenced this issue Jun 28, 2024
@samsrabin
Merge pull request ESCOMP#8 from glemieux/fates-landuse-v2-merge
6a27513 
Bring landuse api up to date with `branch_tags/tmp-240620.n02.ctsm5.2.007`
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Merge pull request ESCOMP#8 from NCAR/modularize_infiltration_p3
0a5a9c8 
Finish Infiltration modularization - mainly h2osfc updates

Finish the modularization of subroutine Infiltration. The main focus
here is modularizing the calculation of fluxes out of h2osfc and the
updates of the h2osfc state variable. Flux calculations and state
updates are now done separately. Where a flux calculation depends on a
partially-updated version of h2osfc, this is now made explicit in a way
that could facilitate removing this partial update later.
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
gdicker1 added a commit to gdicker1/CTSM that referenced this issue Aug 30, 2024
@gdicker1
Merge branch 'update/cesm3_0_beta01/ctsm5.2.007' into ew-develop (PR E…
38b810e 
…SCOMP#8)
slevis-lmwg pushed a commit that referenced this issue Sep 5, 2024
@ekluzek
Merge pull request #8 from ekluzek/add_version_to_srf_datasets
064886f 
Add version to srf datasets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: dependency Wait to work on this until dependency is resolved bug something is working incorrectly science Enhancement to or bug impacting science
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billsacks @samsrabin