experiment bug fix

[TeaganKing]

This PR involves some changes to the arguments in run_case in order to address #2433

Fixes #2433

[wwieder]

Assigning this to @slevis-lmwg to integrate into b4b-dev after @ekluzek is able to approve the PR.

[wwieder]

I should add that I was able to create --transient cases with code mods on this branch.

[wwieder]

@TeaganKing I also see this is marked as a WIP. Was there more you were planning to add to this PR?

[ekluzek]

Marking as approved since it's small and I see no problems with the changes.

This is still marked as a draft, is this ready to come in? Or is there more going on here?

I wasn't sure about the removal of the default values from run_case. Can you elaborate more on why that's being done?

[TeaganKing]

@wwieder I was planning to add fixes for other issues in the same PR, but I think maybe we should keep this as simple as possible since there are lots of moving pieces right now. I wasn't planning to add anything else specifically for the 'experiment' functionality.

[slevis-lmwg]

Testing after merging b4b-neon to this branch (thus, effectively, having merged the latest b4b-dev):
OK: ./run_ctsm_py_tests -u
FAIL: ./run_ctsm_py_tests -s
PASS: ./run_sys_tests -s clm_pymods -c ctsm5.1.dev176 --skip-generate

@TeaganKing two requests:

1. Could you add me as collaborator so that I can push to this PR? You would click on Settings just to the right of middle-top of this page. Then click on Collaborators and follow the instructions for adding me (@slevis-lmwg).
2. The python system testing triggers this error:

ERROR: test_one_site (test.test_sys_run_neon.TestSysRunNeon)
This test specifies a site to run
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/glade/work/slevis/git/latest_master/python/ctsm/test/test_sys_run_neon.py", line 57, in test_one_site
    main("")
  File "/glade/work/slevis/git/latest_master/python/ctsm/site_and_regional/run_neon.py", line 242, in main
    experiment=experiment,
  File "/glade/work/slevis/git/latest_master/python/ctsm/site_and_regional/neon_site.py", line 113, in run_case
    experiment,
  File "/glade/work/slevis/git/latest_master/python/ctsm/site_and_regional/tower_site.py", line 305, in run_case
    self.name = self.name + "." + experiment
TypeError: can only concatenate str (not "NoneType") to str

I think I should send this back to you to fix, unless @wwieder would rather I did the rest of the debugging on this.

[TeaganKing]

Thanks for catching that, @slevis-lmwg . I added you to the repository. I'm not going to be able to fix the system test error tonight, but I think I see what's going on and should have time to fix it tomorrow.

[slevis-lmwg]

Thank you, @TeaganKing

[wwieder]

@TeaganKing is this something that's straight forward for you to address?

Sorry, I wrote this without refreshing my browser looking upstream on the conversation. Thanks @TeaganKing

[TeaganKing]

Hi @slevis-lmwg, I think I fixed the issue.

[slevis-lmwg]

Testing this morning passed:
PASS: make black
PASS: make lint
OK: ./run_ctsm_py_tests -u
OK: ./run_ctsm_py_tests -s
PASS: ./run_sys_tests -s clm_pymods -c ctsm5.1.dev176 --skip-generate

[slevis-lmwg]

For my own sanity, I'm also running
./run_sys_tests -s aux_clm -c ctsm5.1.dev176 --skip-generate
I didn't do so for #2472 before merging it to b4b-dev, so I'm doing it now and hoping for the best...

derecho OK
izumi OK with one test still PENDing, so I will proceed with the merge at this point.