Some lines longer than 132 characters #464
Comments
|
I realized there's an off-by-one error in that script, so things mentioning 133 characters are actually okay. |
|
It turns out that the problems on master were not really problems - the only offending lines were due to trailing whitespace. So the only real problems came in in ctsm1.0.dev005. (I'm running the script with: |
|
That is a neat format checking tool. That is the kind of thing I would like to add to continuous integration if we ever get it running for fates. |
|
@rgknox see also https://github.com/marbl-ecosys/MARBL/blob/development/MARBL_tools/code_consistency.py There are things I like about both of those tools, though neither one works exactly as I'd like right now. |
billsacks
added a commit
that referenced
this issue
Aug 4, 2018
Minor bug fixes, cleanup, documentation and enhancements A collection of minor bug fixes, code cleanup, documentation and enhancements, all bit-for-bit. See list of issues fixed below for details. Issues fixed (include CTSM Issue #): - Fixes #24 (ncd_io_1d_log_glob is broken) - Fixes #120 (Incorrect comments in Biogeophysics1Mod.F90 - Fixes #217 (Change some cheyenne_gnu tests to cheyenne_intel) - Fixes #245 (Put all .gitignore entries in top-level file) - Fixes #272 (Code should error on missing mxsoil_color when SOIL_COLOR is used) - Fixes #283 (Add more helpful message about need to do init_interp with wrong number of vertical layers) - Fixes #367 (For cmip6 runs: Turn on cpl hist output needed to drive a TG compset) - Fixes #412 (Fix documentation of init_interp_method) - Fixes #419 (Do not allow SOYFIXN diagnostic field with FUN) - Fixes #464 (Some lines longer than 132 characters) - Fixes #465 (Remove backwards compatibility check for snw_rds) - Fixes #467 (Increase wallclock limit for test)
billsacks
added a commit
to billsacks/ctsm
that referenced
this issue
Feb 22, 2019
Checked with code-format-checker/CodeFormatChecker.py -t rc -l 133 (Note the off-by-one error in that script, hence the need for 133 rather than 132.) Fixes ESCOMP#464
billsacks
added a commit
to billsacks/ctsm
that referenced
this issue
Feb 22, 2019
Minor bug fixes, cleanup, documentation and enhancements A collection of minor bug fixes, code cleanup, documentation and enhancements, all bit-for-bit. See list of issues fixed below for details. Issues fixed (include CTSM Issue #): - Fixes ESCOMP#24 (ncd_io_1d_log_glob is broken) - Fixes ESCOMP#120 (Incorrect comments in Biogeophysics1Mod.F90 - Fixes ESCOMP#217 (Change some cheyenne_gnu tests to cheyenne_intel) - Fixes ESCOMP#245 (Put all .gitignore entries in top-level file) - Fixes ESCOMP#272 (Code should error on missing mxsoil_color when SOIL_COLOR is used) - Fixes ESCOMP#283 (Add more helpful message about need to do init_interp with wrong number of vertical layers) - Fixes ESCOMP#367 (For cmip6 runs: Turn on cpl hist output needed to drive a TG compset) - Fixes ESCOMP#412 (Fix documentation of init_interp_method) - Fixes ESCOMP#419 (Do not allow SOYFIXN diagnostic field with FUN) - Fixes ESCOMP#464 (Some lines longer than 132 characters) - Fixes ESCOMP#465 (Remove backwards compatibility check for snw_rds) - Fixes ESCOMP#467 (Increase wallclock limit for test)
mariuslam
pushed a commit
to NordicESMhub/ctsm
that referenced
this issue
Aug 26, 2019
Fixed DEBUG to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Brief summary of bug
By running the code through https://github.com/NCAR/code-format-checker, I found a few dozen lines of code that are longer than 132 lines. I'm not sure why our NAG tests didn't pick this up.
General bug information
CTSM version you are using: ctsm1.0.dev004-24-geb61a048 . Some problems are new to this branch, some look to be pre-existing on master.
Does this bug cause significantly incorrect results in the model's science? No (probably not... though it's possible that runs with NAG are working incorrectly)
Configurations affected: Potentially will cause build failures with NAG compiler
Important output or errors that show the problem
The text was updated successfully, but these errors were encountered: