Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comments in Biogeophysics1Mod.F90 #120

Closed
ekluzek opened this issue Dec 16, 2017 · 0 comments
Closed

Incorrect comments in Biogeophysics1Mod.F90 #120

ekluzek opened this issue Dec 16, 2017 · 0 comments
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Milestone
clm5

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 16, 2017

Liang Chen < lchen15 > - 2015-08-18 13:11:28 -0600
Bugzilla Id: 2202
Bugzilla CC: rfisher,

In Biogeophysics1Mod.F90, the variables hr is not relative humidity, but the alpha soil (Equation 5.73 in CLM45_Tech_Note).

real(r8) :: hr      !relative humidity
real(r8) :: hr_road_perv  !relative humidity for urban pervious road
@ekluzek ekluzek added this to the clm5 milestone Dec 16, 2017
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Dec 16, 2017
@billsacks billsacks added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb and removed enhancement new capability or improved behavior of existing capability tag: simple bfb code health improving internal code structure to make easier to maintain (sustainability) labels Jan 25, 2018
@billsacks billsacks added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb and removed type: docs - code labels Feb 13, 2018
billsacks added a commit to billsacks/ctsm that referenced this issue Aug 3, 2018
@billsacks
Fix documentation of hr and hr_road_perv
4e0422b 
Fixes ESCOMP#120
billsacks added a commit that referenced this issue Aug 4, 2018
@billsacks
Merge branch 'simple_bfb_v2'
8ad23e5 
Minor bug fixes, cleanup, documentation and enhancements

A collection of minor bug fixes, code cleanup, documentation and
enhancements, all bit-for-bit. See list of issues fixed below for
details.

Issues fixed (include CTSM Issue #):
- Fixes #24 (ncd_io_1d_log_glob is broken)
- Fixes #120 (Incorrect comments in Biogeophysics1Mod.F90
- Fixes #217 (Change some cheyenne_gnu tests to cheyenne_intel)
- Fixes #245 (Put all .gitignore entries in top-level file)
- Fixes #272 (Code should error on missing mxsoil_color when SOIL_COLOR
  is used)
- Fixes #283 (Add more helpful message about need to do init_interp with
  wrong number of vertical layers)
- Fixes #367 (For cmip6 runs: Turn on cpl hist output needed to drive a
  TG compset)
- Fixes #412 (Fix documentation of init_interp_method)
- Fixes #419 (Do not allow SOYFIXN diagnostic field with FUN)
- Fixes #464 (Some lines longer than 132 characters)
- Fixes #465 (Remove backwards compatibility check for snw_rds)
- Fixes #467 (Increase wallclock limit for test)
@billsacks billsacks mentioned this issue Aug 4, 2018
Merged
billsacks added a commit to billsacks/ctsm that referenced this issue Feb 22, 2019
@billsacks
Fix documentation of hr and hr_road_perv
4f7c6f8 
Fixes ESCOMP#120
billsacks added a commit to billsacks/ctsm that referenced this issue Feb 22, 2019
@billsacks
Merge branch 'simple_bfb_v2'
ab93e69 
Minor bug fixes, cleanup, documentation and enhancements

A collection of minor bug fixes, code cleanup, documentation and
enhancements, all bit-for-bit. See list of issues fixed below for
details.

Issues fixed (include CTSM Issue #):
- Fixes ESCOMP#24 (ncd_io_1d_log_glob is broken)
- Fixes ESCOMP#120 (Incorrect comments in Biogeophysics1Mod.F90
- Fixes ESCOMP#217 (Change some cheyenne_gnu tests to cheyenne_intel)
- Fixes ESCOMP#245 (Put all .gitignore entries in top-level file)
- Fixes ESCOMP#272 (Code should error on missing mxsoil_color when SOIL_COLOR
  is used)
- Fixes ESCOMP#283 (Add more helpful message about need to do init_interp with
  wrong number of vertical layers)
- Fixes ESCOMP#367 (For cmip6 runs: Turn on cpl hist output needed to drive a
  TG compset)
- Fixes ESCOMP#412 (Fix documentation of init_interp_method)
- Fixes ESCOMP#419 (Do not allow SOYFIXN diagnostic field with FUN)
- Fixes ESCOMP#464 (Some lines longer than 132 characters)
- Fixes ESCOMP#465 (Remove backwards compatibility check for snw_rds)
- Fixes ESCOMP#467 (Increase wallclock limit for test)
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Fix documentation of hr and hr_road_perv
5aac6b1 
Fixes ESCOMP#120
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Fix documentation of hr and hr_road_perv
2bb1746 
Fixes ESCOMP#120
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Milestone
clm5
Development

No branches or pull requests
3 participants
@billsacks @samsrabin @ekluzek