Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparative benchmarks with Taffy 0.3 #572

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

nicoburns
Copy link
Collaborator

Objective

Allow us to determine how performance has changed since the last major Taffy version.

Changes made

  • Depend on Taffy 0.3 (as well as current Taffy) in the benchmarks create
  • Implement BuildTree trait for Taffy 0.3
  • Add a taffy03 feature flag which runs benchmarks against Taffy 0.3
  • Simplify benchmarking code with macros

Context

Since we refactored the benchmarks in #472, simply checking out the old branch no longer gives a useful comparison.

@nicoburns nicoburns added the benchmarks Measuring performance label Oct 29, 2023
@nicoburns nicoburns merged commit c16e2b6 into DioxusLabs:main Oct 29, 2023
21 checks passed
@nicoburns nicoburns deleted the taffy-03-benches branch October 29, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Measuring performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant