-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor benchmarks #472
Refactor benchmarks #472
Conversation
9c06887
to
e4f7762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this direction, and I think the abstraction pays off. Definitely agree that we need to ensure we're using exactly the same trees.
e4f7762
to
048ce19
Compare
048ce19
to
6cc0cd0
Compare
6cc0cd0
to
d07ee4c
Compare
d07ee4c
to
39443ae
Compare
- Abstract tree creation behind a trait - Implement trait for Yoga and Taffy
39443ae
to
043c951
Compare
54291c2
to
379bbfa
Compare
Marking this as ready for review / merging. I'm seeing much more consistent results with this PR now. I have checked, and it seems to me that the tree structures are now the same (I think I must have fixed this ages ago). I've also tried out different random seeds, and it doesn't seem to make that much difference (+-5%, and movement in the same direction for both Taffy and Yoga). |
Objective
Changes made
Notes
This change seems to have changed some of the benchmark results quite a bit, which I believe is due to a change in node creation order, which interacts with the randomly generated node styles. This suggests that we ought to make sure that the Yoga and Taffy trees are being created in exactly the same order (so that exactly the same tree is created). I'd also like to play around with different random seeds and see how this affect things.
Feedback wanted