PSR-12 conversion #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to remove JCOMPAT_UNICODE_PROPERTIES constants from global namespace and replace it with a static variable within the test function. This is a preparation for PSR12 transformation to satisfy PSR1.Files.SideEffects.FoundWithSymbols rule. Beside that it doesn't make sense to declare a global constant which is only used in the local class.
The handler auto register should have been removed in Joomla! 4.0.
* Move demo tasks to service provider * Update plugins/task/demotasks/services/provider.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
…controllers (joomla#38103) * Replace Factory::getApplication() by $this->app in component's controllers * Remove un-used import. Thanks @Quy Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Franciska Perisa <9084265+fancyFranci@users.noreply.github.com>
* <supported_databases> in updates XML always resulted in an error * Use uppercase for array key and language string key Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* Remove the item vue and merge it into the tree vue for ease * Add accessible keyboard support for the media manager disk view
* Refactored WebAuthn plugin * Fix the WebAuthn management page which was broken in joomla#37464 * Fix wrong `@since` doc tag * Fix docblock typo * Fix docblock typo * Fix docblock typo * Fix docblock typo * Fix docblock typo * Fix broken management interface * Make unnecessarily static method back into non-static * Replace static helper with injected object * Come on, commit the ENTIRE file! * Use the user factory * Fix error when going through the user factory * Fix: cannot add WebAuthn authenticator right back after deleting it * Remove useless switch branch * Remove useless exception * Display make and model of the authenticator, if possible * Add missing JWT signature algorithms * Fix copyright date * Fix for PHP 8 using FIDO keys and Android phones * Reactivate the tooltips after adding an authenticator * Option to disable the attestation support * The Windows Hello icon was invisible on white background * Attempt to fix Appveyor not having Sodium in the Windows build * Work around third party library bug... * Create events in a forwards-compatible manner * Concrete events * Fix event woes * Update plugins/system/webauthn/webauthn.xml Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/plg_system_webauthn.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Improve the layout for editing an authenticator It now follows the Bootstrap 5 form aesthetic. Moreover, there are gaps between the text input and the Save and Cancel buttons. * Confirm deletion of authenticators * Make the bots happy again * Code polishing * Marking classes final * Use setApplication / getApplication in the plugin class * Remove unused `$db` from the plugin class * Blind fix Currently joomla#38060 has broken everything it seems? * Bring application injection in sync with core * Remove whitespace * Add use statement * Fix wrong event creation in AjaxHandlerLogin * License change Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Roland Dalmulder <contact@rolandd.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Harald Leithner <leithner@itronic.at> Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Thanks to @brianteeman
PSR12 transformation preparation
[4.2] Change Codestyle to PSR-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests converts the branch to the PSR-12 coding standard.